45524 - Mail Compose: Toolbar buttons should have dropdown menus

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[jglick]

Mail Compose: Toolbar Buttons: Dropdown Menus

Several of the Mail Compose Toolbar buttons should have drop down menus with 
additional functionality. Clicking the button gets the default behavior. 
Clicking the button menu allows additional functionality.

These dropdowns should have the same UI (look/functionality) as the browser 
buttons (Back, Forward).

Attach - Clicking on the button displays a dropdown menu which allows user to 
choose: File or Web Page. Default - File.

Save - Clicking on the button saves the current messages as a Draft by default. 
Clicking on the dropdown button allows the user to choose whether to save the 
message as a File, Draft or Template.

http://gooey/client/5.0/specs/mail/Compose/Compose.html#ToolbarButtons

Comment 1

[jglick]

nominate as b3mail to be reviewed for potential nsbeta3.

Comment 2

[selmer (gone)]

change b3mail to nsbeta3.

Comment 3

[lchiang]

nsbeta3- This is available from the menus.

Comment 4

[lchiang]

*** Bug 39745 has been marked as a duplicate of this bug. ***

Comment 5

[jglick]

Add mail3 keyword so bug will be considered for 6.5

Comment 6

[Fabian Guisset]

*** Bug 61720 has been marked as a duplicate of this bug. ***

Comment 7

[Fabian Guisset]

Ok I have done this on my Mozilla, and it seems to work fine. However this
modifies the themes, as it involves turning two buttons into menubuttons, thus
requiring updates in messengercompose.css . I have tried to do it on my Mozilla,
but I don't know much about css so I just CC Hewitt to have his input. The
needed changes are :
Modify
#button-attach
#button-save
in order to turn them into menubuttons. I copied the print menubutton from
messenger.css and it works fine except for a few focus problems, so this
shouldn't be too much trouble.
Note : this fix doesn't involve changing features, it just adds an easier way to
access those features, so it is a safe fix, I believe.
Fabian.

Comment 8

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8.  This is only for the attach button.
the others can wait.

Comment 9

[Fabian Guisset]

Attachment: Attempt to add a menubutton for the attach toolbar shortcut

Comment 10

[Fabian Guisset]

Diff file. Adds a menubutton to the attach toolbar shortcut. Diff includes
changes to messengercompose.xul and messengercompose.css (modern only). Classic
theme seems to work without changing its messengercompose.css.
Didn't bother with blue theme.
Hope this helps. Fabian.

Comment 11

[Jean-Francois Ducarroz]

Thanks for the patch, I will take a look at it later...

Comment 12

[scottputterman]

moving to mozilla0.9, but JF could you take a look at this when you get a chance?

Comment 13

[scottputterman]

marking nsbeta1-. However, if there's a patch, let's get this in.

Comment 14

[varada]

Re-assigning bugs to varada.

Comment 15

[scottputterman]

moving to future, but as I said, if the patch is good we can get it in.

Comment 16

[[e-mail]]

I would like to see the (commented) separator/attach signature/vcard items
copied so that should they get implemented someone might remember to do both copies.

Assuming that the attach button never needs to be disabled the patch works fine.

Comment 17

[varada]

Attachment: Patch for pulldown menu for Attach and Save Buttons.

Patch for pulldown menu for Attach and Save Buttons.

Comment 18

[Jean-Francois Ducarroz]

Comment on attachment 88558 [details] [diff] [review]
Patch for pulldown menu for Attach and Save Buttons.

the patch looks good but before I could say R=, I would like to know if it's ok
with UI folk to do that!

Comment 19

[Jean-Francois Ducarroz]

Comment on attachment 88558 [details] [diff] [review]
Patch for pulldown menu for Attach and Save Buttons.

oh, I did not see that jennifer was the reporter! I conclude it's a request
from the UI folk. R=ducarroz

Comment 20

[jglick]

OK with me. :-)

Comment 21

[[e-mail]]

Attachment: Alternate version

This uses event.preventBubble() to keep the use of command= on the buttons.
I've also added a dropdown for the Send button, because for some reason people
can't seem to find Send Later.

Comment 22

[[e-mail]]

Attachment: Forgot themes changes

Added in themes changes, otherwise buttons won't hover properly.

Comment 23

[[e-mail]]

Attachment: Don't need preventBubble after all

After rereading xul menu code the preventBubble isn't necessary.

Comment 24

[Jean-Francois Ducarroz]

Comment on attachment 108365 [details] [diff] [review]
Don't need preventBubble after all

R=ducarroz

Comment 25

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 26

[(not reading, please use [e-mail] instead)]

from the spec:

Send  	

Sends the current message. If the user on online, the messages is sent right
away.  If the user is off-line the message is saved to the "Unsent Messages"
folder. 

[no mention of the send or send later.  about this, what would it mean to do
"send" when offline?]

Attach 	

Used to attach a File, Web Page or vCard to a message.  Clicking on the button
displays a dropdown menu which allows user to choose: File, Web Page or Personal
Card (vCard).

[we don't really have vCard support, so that's left off in your patch]

Save 	

Clicking on the button saves the current messages as a Draft. Clicking on the
dropdown button allows the user to choose whether to save the message as a File,
Draft or Template.

neil, can you screen shot how this looks in modern and classic?

also, how does it behave?

for comparison, looking at 4.x (win32),
for send, no dropdown menuitems (like in the spec)
for attach, right click does nothing, but left click gives you menuitems.
for save, left click does a save as draft.  you'd only see the menuitems if you
right clicked. 

note, in mozilla the tooltip for attach is "Attach a file to this message"
in 4.x, it was "Include an attachment", which makes more sense if you can do
file or webpage.

looking at the compose toolbar security button in mozilla, these types of
buttons behave differently in mozilla than they did in 4.x.

to summarize:

1) I don't think we want the change to the send button
2) can you get some screen shots of modern and classic
3) can you fix the attach tooltip?

Comment 27

[[e-mail]]

Attachment: Screenshot (Modern)

Comment 28

[[e-mail]]

Attachment: Screenshot (Classic)

Comment 29

[Peter Lairo]

Should there be some visual clue (bold?) in the dropdown as to which is the
default action (of the big button)?

BTW, awesome screenshots! Thanks for making progress on this! :-D

Comment 30

[jglick]

Looks good. Thanks for the great work.

>1) I don't think we want the change to the send button
Correct.

Comment 31

[[e-mail]]

Attachment: Just attach and save

Comment 32

[(not reading, please use [e-mail] instead)]

Comment on attachment 108365 [details] [diff] [review]
Don't need preventBubble after all

obsolete

Comment 33

[(not reading, please use [e-mail] instead)]

Comment on attachment 108365 [details] [diff] [review]
Don't need preventBubble after all

sr=sspitzer, thanks neil.

Comment 34

[(not reading, please use [e-mail] instead)]

Comment on attachment 108365 [details] [diff] [review]
Don't need preventBubble after all

wrong patch

Comment 35

[(not reading, please use [e-mail] instead)]

Comment on attachment 117487 [details] [diff] [review]
Just attach and save

r/sr=sspitzer, thanks neil.

Comment 36

[[e-mail]]

Fix checked in.

Comment 37

[jglick]

Just a nit.

Attach menu should have "File(s)..." and "Web Page..." not "Attach File(s)" and
"Attach Web Page...". (Attach is the name of the button so it doesn't need to be
duplicated).

Just like Save menu has "File...", "Draft", and "Template", not "Save File...",
Save Draft" and "Save Template".

Comment 38

[[e-mail]]

OK, so what about the attachment bucket context menu, should that say "Attach
File(s)..." as well? (should that have "Attach Web Page..." added as well?)

Comment 39

[jglick]

>OK, so what about the attachment bucket context menu, should that say "Attach
>File(s)..." as well? (should that have "Attach Web Page..." added as well?)

Do you mean in Mail Compose: Attachment area: Context menu.

Changing "Add Attachment", to "Attach File(s)..."? Yeah, probably should, but
not a rush (no major usability harm ;-)


I don't think we need to add "Attach Web Page..." in addition. Context menus
provide quick assess to the most common actions, not all the available actions.
I know the existing context menu is small, but i like to consistency following
that guideline. 

Comment 40

[[e-mail]]

Attachment: String fixes

Comment 41

[(not reading, please use [e-mail] instead)]

Comment on attachment 118288 [details] [diff] [review]
String fixes

r/sr=sspitzer, thanks neil.

Comment 42

[Peter Lairo]

The current nightlies' (2003-08-10) tooltip still doesn't say "Include an
attachment", as requested by Seth in comment #26. REOPEN?

Comment 43

[[e-mail]]

Checked in the string fixes at last :-[

Comment 44

[Daniel Wang]

v