455627 - NPN_UserAgent() cannot handle user agents over 128 bytes, returns NULL

Status: RESOLVED DUPLICATE of bug 328778

(Firefox :: General, defect)

Description

[Rudi Sherry]

Adding enough characters to the user agent using "general.useragent.extra.xyz" will cause NPN_UserAgent() to return NULL.  nspluginhostimpl.cpp has nsPluginHodstImpl::UserAgent() which has a static string of 128 bytes.

This is the cause of one Reader crash in bug 448102.

Microsoft.NET adds some user-agent (according to that bug), and perhaps other installations to.  Once it hits over 128 bytes, Reader 8.1 and later will always crash.

I'm working on fixing the Reader crash, but there are other issues; we sniff the UserAgent to allow some capabilities, and with NULL we have to assume it's an unsupported browser.

This is in both the 3.0 branch and the 2.0 branch.

Comment 1

[WADA:World Anti-bad-Duping Agency]

DUP of already fixed Bug 328778, isn't it?
(Bug 451944 and Bug 416286 are already closed as DUP of Bug 328778)
If you need fix on Fx 3.0.3(seems to be too late for Fx 3.0.2), add "wanted 1.9.0.x" flag in Bug 328778, instead of open separate bug for branch only issue.