45808 - Linux: Cannot get focus in file input textfield

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[Chris McAfee]

Linux.
Try and create a patch for bug 40698, by
typing in a pathname for a file into the patch location
text field (file picker widget).  you never get focus!
Note that using the browse... button seems to work.

Comment 1

[Chris McAfee]

oh let's pick on this bug instead of another one,
URL now points at this bug.

Comment 2

[R.K.Aa.]

related to bug 45749 perhaps?

Comment 3

[John Morrison]

Say, Chris, do you mean the HTML <input type="file"> in the attachment page
(which, yes, does not apparently get focus). When I saw this earlier I assumed
you meant pav's filepicker.

In a testcase, html onfocus and onblur event handlers seem to say that the focus
leaves the ender widget as soon as it arrives (but I could be reading that
wrong). [This is linux only; the testcase works on mac and win32]. Looks like an
mjudge/saari/pavlov thing

Comment 4

[John Morrison]

Attachment: testcase; simple <input type="file">

Comment 5

[Chris McAfee]

this is needed for basic bugzilla usage, nominating
for nsbeta2.

Comment 6

[Jay Patel [:jay]]

Putting on [NEED INFO] radar. PDT needs to know impact to user.  Why is using 
browse not a sufficient way to pick a file?  The user can still type in the file 
into the field in the browse window right?

Comment 7

[Chris McAfee]

user should be able to type full file path in.
browse... button is acceptable workaround, but !
who knows how many other things are broken.

Comment 8

[Chris McAfee]

saari

Comment 9

[Chris McAfee]

browse... button is acceptable workaround, but this is pretty broken
and a fix should be taken for nsbeta2+ if possible.

Comment 10

[Brian Ryner (not reading)]

Making the summary more accurate, so that this doesn't sound like a filepicker
bug.

Comment 11

[Peter Trudelle]

This is broken, but with an obvious workaround.  Annoying, but it does not fit
the criteria we are using for triaging for nsbeta2. Must fix for release,
nominating for nsbeta3.

Comment 12

[Chris McAfee]

reiterating, we should take a fix for this if there is one, for beta2.

Comment 13

[saari (gone)]

This is obnoxiously broken... I'm looking at it now

Comment 14

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 15

[Akkana Peck]

I'm seeing this, too.  I have to use middle-mouse-paste to attach anything to a
bug.

Comment 16

[Peter Trudelle]

Adding nsbeta3+, assigning to bryner 

Comment 17

[Brian Ryner (not reading)]

Really assigning to me.

Comment 18

[Brian Ryner (not reading)]

Checked in a fix.

Comment 19

[Christopher Blizzard (:blizzard)]

This should really go into the M17 branch as well.

Comment 20

[Christopher Blizzard (:blizzard)]

Attachment: patch that was checked in

Comment 21

[Daniel (Leaf) Nunes]

re-nominating for nsbeta2; we have a fix in hand and it isn't very dangerous;
this will affect the useability of the beta for at least people in our
engineering groups. we even have non-netscape engineers ready to commit and test
the change.

Comment 22

[Christopher Blizzard (:blizzard)]

reassign

Comment 23

[leger]

We cannot take risk for PR2 at this time.  Putting on [nsbeta2-] radar.  
Workaround is to use Browser button. Putting on relnote2 radar.

Comment 24

[Christopher Blizzard (:blizzard)]

This is checked into the tip.  No need to keep it open.  I'll just patch the
RPMS I distribute of M17.

Comment 25

[Christopher Blizzard (:blizzard)]

Closing

Comment 26

[Brian Ryner (not reading)]

Reopening so I can set this to RESOLVED, so it will show up on QA's radar.

Comment 27

[Brian Ryner (not reading)]

This is checked in.

Comment 28

[Vladimir Ermakov]

Verifying on Build 2000-09-18-06-M18
Platform:
  -Red Hat 6.2