46068 - even support for focus event doesn't worked

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Vladimir Strigun]

When we call any of these two methods of WindowControl interface
 void removeFocus()                  
 void setFocus() 
and try to catch the events by regestring event listeners in JavaScript
e.g. window.addEventListener("focus", onFocusGained, false))
in the preliminarily loaded page it doesn't work (no events are caught).
Supposed reason: Even support is unimplemented yet, so code must thrown a 
UNIMPLEMENTED exception

Comment 1

[Asa Dotzler [:asa]]

updating product, component and setting default owner.

Comment 2

[Johnny Stenback (:jst)]

Please attach a concrete minimized testcase that points out the problem here,
thanks!

Comment 3

[Johnny Stenback (:jst)]

Still no testcase here, reassigning to joki who might know why/what/when about
this...

Comment 4

[Vladimir Strigun]

Change component, QA contact and assign to Ed Burns - default module owner for 
Webclient

Comment 5

[Vladimir Strigun]

Reassing to Ed Burns

Comment 6

[edburns]

Reassign to Ashu for investigation.

Comment 7

[Ashu Kulkarni]

SetFocus funtion in WindowControl calls into the Mozilla
nsIBaseWindow->SetFocus() function. If there is a disconnect here, it is most
probably because something here was broken in the embedding APIs (that gave
access to nsIBaseWindow object) at the time M16 was released.

RemoveFocus - support for this was removed from M15 onwards. Hence there is no
Embedding API by which this functionality can be exposed to the Webclient users.
I will make this throw an UnImplementedException and check in the change. Will
also follow up with Mozilla Embedding folks to find out if this functionality
might come back later.

_Ashu

Comment 8

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u WindowControlImpl.java

Comment 9

[Ashu Kulkarni]

I have a temporary patch for this that throws UnImplementedException for these 2
methods. Will check in once I have r=a=edburns.

_Ashu

Comment 10

[edburns]

r=a=edburns

Comment 11

[Ashu Kulkarni]

Checked patch into cvs that throws UnImplementedException. I wont close this Bug
as yet. After we sync up with the PR3 branch, I'll check if this persists...and
only then will I close/work on this bug.

_Ashu

Comment 12

[geetha.vaidyanaathan]

Adding Status white board keyword to track all existing Webclient bugs

Comment 13

[Ashu Kulkarni]

Attachment: cvs diff -u of WindowControlImpl.java

Comment 14

[Ashu Kulkarni]

I have changed WindowControlImpl.java so that it calls into Native code 
(nsIBaseWindow->SetFocus)when SetFocus is called (instead of throwing 
UnImplementedException). I have also changed the comment in the Exception 
thrown when RemoveFocus is called to indicate that RemoveFocus is no longer 
supported by Mozilla. This function does not make much sense anyways 
considering that SetFocus is provided to Embedders who wish to have the ability 
to TAB through the page being displayed. We should seriously consider removing 
this Function from the API.

QA, pls test whether SetFocus works with your API tests using the 
Netscape6_0_OEM_Branch mozilla codebase. I know this didn't work with M16. 

Ed, do I have ra=edburns for checking this in?

thnx
_Ashu

Comment 15

[edburns]

Looks good.  r=edburns

Comment 16

[Ashu Kulkarni]

SetFocus seems to work and RemoveFocus is no longer supported in Gecko 
Embedding. Would the reporter pls verify that the SetFocus works. I am closing 
this Bug.

Comment 17

[Vladimir Strigun]

Mark this bug as verified.
Verified with Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.1) Gecko/20010910

Comment 18

[Vladimir Strigun]

Change cc