46290 - relative font buttons don't work on text specified with abs size

Status: VERIFIED FIXED

(Core :: DOM: Editor, enhancement, P4)

Description

[Akkana Peck]

Someone sent me mail with <font face=Arial size=2>, which is completely
unreadable to me.
I replied to it in html mail compose.  I selected the quoted text, then hit
"bigger" a few times, but nothing happened.  So I changed the font face to
Variable Width via the toolbar dropdown; now it was my normal font, but it was
still too small.  Hitting bigger still had no effect, nor did Format->Size->Medium.

Eventually I discovered that Format->Remove All Text Styles did the trick (and
was what I should have done in the first place), but I think we should try to
make bigger/smaller work even for fonts specified in absolute sizes, since
that's the most obvious thing for a user to do when confronted with too-small fonts.

Comment 1

[rubydoo123]

if we wanted to adjust abs set fonts, then we would need to remove the font 
specification wouldn't we? Marking this as future

Comment 2

[Akkana Peck]

Maybe we should remove the font specification, then.  It's very confusing as a
user to have buttons that say they'll do something, but really do nothing.

Comment 3

[rubydoo123]

It seems that the "smaller"/"larger" doesn't work if selection spans across 
text that has <font size="x"> , but it does work if selection is within the 
font tag.

Comment 4

[rubydoo123]

forgot to add correctness

Comment 5

[Joe Francis]

nominating for b3.  i believe i can fix this without too much trouble.  

Comment 6

[rubydoo123]

setting to nsbeta3+

Comment 7

[rubydoo123]

due to the timeframe and the number of issues that need to be addressed, marking 
this as nsbeta3-, adding helpwanted and moving to future

Comment 8

[rubydoo123]

*** Bug 54313 has been marked as a duplicate of this bug. ***

Comment 9

[Joe Francis]

pulling this back to 096 from future because I have a PLAN.

Comment 10

[Joe Francis]

*** Bug 99406 has been marked as a duplicate of this bug. ***

Comment 11

[Joe Francis]

Attachment: nsHTMLEditorStyle.cpp

Comment 12

[Joe Francis]

Attachment: nsHTMLEditor.h

Comment 13

[Joe Francis]

above patch fixes problem plus does better job at mergin bigs and small where
possible.

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 53169 [details] [diff] [review]
nsHTMLEditorStyle.cpp

You should not remove a font element if the size attribute is not the only
attribute carried by the element.

Comment 15

[Joe Francis]

hmm, at the time I thought I knew what Daniel was talking about.  Looking at it
now, though, I don't.  I didn't add any code in the patch that removes font
nodes.  It's true thatI remove bigs & smalls in certain circumstances without
looking to see if they have attributes, but this is not a change from similar
pre-patch code.

Comment 16

[Joe Francis]

fix checked in on trunk

Comment 17

[rubydoo123]

gratuitous verify : it's been checked in for a really long time. Who did the r=
and sr=?