463578 - Assertion running browser/components/privatebrowsing/test/unit/test_privatebrowsing_exit.js in debug builds

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Jeff Walden [:Waldo]]

TEST-UNEXPECTED-FAIL | ../../../../_tests/xpcshell-simple/test_privatebrowsing/unit/test_privatebrowsing_exit.js | test failed, see log
../../../../_tests/xpcshell-simple/test_privatebrowsing/unit/test_privatebrowsing_exit.js.log:
>>>>>>>
*** test pending
pldhash: for the table at address 0x361b40, the given entrySize of 80 definitely favors chaining over double hashing.
*** test pending
*** test finished
###!!! ASSERTION: consider quit stopper out of bounds: 'mConsiderQuitStopper > 0', file /Users/jwalden/moz/2/toolkit/components/startup/src/nsAppStartup.cpp, line 412
nsAppStartup::ExitLastWindowClosingSurvivalArea() (/Users/jwalden/moz/2/toolkit/components/startup/src/nsAppStartup.cpp:412)
nsAppStartup::AttemptingQuit(int) (/Users/jwalden/moz/2/toolkit/components/startup/src/nsAppStartup.cpp:349)
nsAppStartup::Quit(unsigned int) (/Users/jwalden/moz/2/toolkit/components/startup/src/nsAppStartup.cpp:255)
NS_InvokeByIndex_P (/Users/jwalden/moz/2/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179)
XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) (/Users/jwalden/moz/2/js/src/xpconnect/src/xpcwrappednative.cpp:2405)
XPC_WN_CallMethod(JSContext*, JSObject*, unsigned int, long*, long*) (/Users/jwalden/moz/2/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1477)
js_Invoke (/Users/jwalden/moz/2/js/src/jsinterp.cpp:1306)
js_Interpret (/Users/jwalden/moz/2/js/src/jsinterp.cpp:5015)
js_Execute (/Users/jwalden/moz/2/js/src/jsinterp.cpp:1550)
JS_ExecuteScript (/Users/jwalden/moz/2/js/src/jsapi.cpp:5071)
ProcessFile(JSContext*, JSObject*, char const*, __sFILE*, int) (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:697)
Process(JSContext*, JSObject*, char const*, int) (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:776)
ProcessArgs(JSContext*, JSObject*, char**, int) (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:895)
main (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:1499)
_start (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:208)
start (/Users/jwalden/moz/2/js/src/xpconnect/shell/xpcshell.cpp:208)

<<<<<<<

The offending line is the |appStartup.quit(Ci.nsIAppStartup.eForceQuit)| line, not surprisingly.  I don't know, but I suspect you cannot legally call this method from xpcshell.  bsmedberg?

Comment 1

[Jeff Walden [:Waldo]]

By the way, this is the only other assertion I hit in xpcshell tests, so don't have any others to worry about.  ;-)

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

If quit-application and friends are borken, we'd be bad anyway.  Just simulate it.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 346937 [details] [diff] [review]
v1.0

Seems to me that appStartup.quit should work without asserting even if there are no windows. File a bug?

Comment 4

[Shawn Wilsher :sdwilsh]

It seems like that code always wants to actually check RealQuitStoppers too, but I"m not sure.  Won't file a bug until we hear from bsmedberg.

http://hg.mozilla.org/mozilla-central/rev/b7b596d41831

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks fine with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081227 Minefield/3.2a1pre ID:20081227165044