Closed Bug 46456 Opened 24 years ago Closed 23 years ago

Cannot drag links into personal toolbar

Categories

(SeaMonkey :: Bookmarks & History, defect, P1)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: zach, Assigned: hewitt)

References

Details

(Whiteboard: no eta)

Attachments

(1 file)

fix feedback stuff
6.83 KB, patch
Details | Diff | Splinter Review 
Mozilla will not allow you to drag links into the personal toolbar as you can 
do in netscape 4 and MISE.
Drop on the toolbar is not supported.  See Pinkerton's comments on bug 21510.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
*** Bug 46457 has been marked as a duplicate of this bug. ***
Wait, I am a stupid man.  *Drops* are supported, but not *drags*.  Reopening and
confirming.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Edit|Preferences. In the 'Debug' pane under Miscellaneous click on 'Personal Toolbar Drag & Drop (buggy)'

I'm not exactly sure what the disposition of bugs like this should be (or if there's a dupe), given the state of toolbar D&D. Pink 
knows though, so I'm reassigning to him and I'll learn from this one.
Assignee: slamm → pinkerton
Status: REOPENED → NEW
future
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Note that an unfortunate side effect of this bug is that if you drag and drop a
bookmark you've created onto the "Bookmarks Toolbar" (which I think is the new
name for what we used to call the Personal Toolbar), the link does get added to
the Bookmarks pulldown menu UI (visible and usable via Bookmarks-->Bookmark
Toolbar-->W3), but not on the Bookmark Toolbar itself, which is confusingly
inconsistent to the user.
Eric, you got this error to happen with the pref I mentioned turned off? I am completely unable to reproduce this on any platform.
If this is happening then I would consider it a more significant failure. with m17 branch builds and the 2000080414-m18 builds

I'm confused.  The original bug here is invalid because d&d works if you turn it 
on (and it will be on by default shortly).  I'm away, but per Eric's comment, 
the personal toolbar is now the bookmarks toolbar?
Sorry, I was running in the default configuration, which from your comments 
appears to mean that this functionality was disabled. (Didn't know about the 
existence of this pref.) Per your other comments, sounds like this will soon be 
on by default, so I'm closing this as INVALID.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → INVALID
soon be on by default? with all the crashes that we know people will encounter 
futured?

er...which crashes are these?  I know of one, regarding drop-in folders, and 
Ben said he'd get hyatt to take a look.
this has never worked for me
*** Bug 56609 has been marked as a duplicate of this bug. ***
*** Bug 56609 has been marked as a duplicate of this bug. ***
I think this bug as originally reported should be 'futured' but not invalid.
repening.
Status: RESOLVED → REOPENED
OS: All
Resolution: INVALID → ---
So will it be enabled by default or not? BTW in is not only Mac...
pushing over to BenG for him to turn this feature back on post ns6.
Assignee: pinkerton → ben
Status: REOPENED → NEW
Target Milestone: Future → mozilla0.9
I think this is the same as bug 44413.
Adding dependency on bug 56805.
Depends on: 56805
*** Bug 44413 has been marked as a duplicate of this bug. ***
Hardware: Macintosh → All
*** Bug 63753 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1
No longer depends on: 56805
i turned this feature on in prefs, but it still doesn#t work!!! does it need a
restart???
Nope, this feature definetely doesn't work yet (latest build and milestone0.7).
Any progress so far?
Netscape Nav triage team: important for daily usage
Priority: P3 → P1
*** Bug 66416 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
*** Bug 68584 has been marked as a duplicate of this bug. ***
Mass moving most of mozilla0.9 bugs to mozilla0.8.1
Target Milestone: mozilla0.9 → mozilla0.8.1
*** Bug 70839 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla0.8.1 → mozilla0.9
Depends on: 42692
Reassigning to alecf since he's working on this. Alecf, if this is a dupe of 
another bug on your plate feel free to mark this as such.
Assignee: ben → alecf
Status: ASSIGNED → NEW
Keywords: nsbeta1 → nsbeta1+
Depends on: 53403
*** Bug 42692 has been marked as a duplicate of this bug. ***
unfortunately, I did not even have time to look at this for moz 0.9. Moving to
0.9.1 and maintaining priority.. sorry!
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9 → mozilla0.9.1
*** Bug 77416 has been marked as a duplicate of this bug. ***
*** Bug 77417 has been marked as a duplicate of this bug. ***
hight time for keyword: *Mostfreq* - sooo many dupes :)

I would also suggest *nsCatFood* because this is a serious user satisfaction issue.
alright already, I'm working in it.
Please no advocacy in bugs, let's keep the discussion to technical issues!

    
    

    
  
ok, this by no means fixes this bug, but it updates the visual feedback when
you're doing a drag/drop.. the actual drop is somewhat broken.
looking for r=/sr=

A few things this does:
- adds some bulletproofing
- fixes it so that for toolbar bookmarks, you can only drag to the left or
right, but not on top...and for folders you can drag on top, or to the left or right
- adds pleasant visual feedback for these behaviors, such as a 3d outline around
folders that you're dropping onto
- cleans up some of the drag on/after/before stuff so we don't have to know what
magic numbers like "-1" mean and can use constants instead.


    
    

    
  
add pink to the CC, I think he's supposed to help me :)

    
    

    
  
Alec, is dragging a URL from the personal toolbar to the bookmarks sidebar tab 
also covered by this? thanks, vishy

    
    

    
  
also, is dragging and dropping within the toolbar (i.e. reordering p toolbar 
elements by dnd) covered by this bug? 

    
    

    
  
no, and no... 

    
    

    
  
Alec/Pink how's this going? Are we going to make it for mozilla0.9.1 on this? 

    
    

    
  
I've checked in everything I have and have been focusing on startup performance,
as I explained last week

    
    

    
  
as i seemed to inherit a slew of critical/crasher bugs while i was on vacation, i 
don't believe i'll have time to help alecf.


    
    

    
  
*** Bug 79959 has been marked as a duplicate of this bug. ***

    
    

    
  
This is a show stopper, IMO.  Of the complaints about N6, this was one of the
top 3. 

    
    

    
  
just an update that no progress has been made on this beyond the feedback
itself.. I'm swamped with startup performance work... :( I agree this is an N6.5
rtm stopper, but can we get by nsbeta1 without it?
URL: N/A
Whiteboard: no eta

    
    

    
  
i'm not sure this is even an rtm stopper. i'd rather we focus development effort 
on fixing speed, stability, and making the features we currently have work before 
we spend more time working on new ones.


    
    

    
  
thanks for the update. yes we're considering postponing to rtm or getting ben to 
work on it. 

    
    

    
  
At the moment this is not a feature but a bug because the Personal Toolbar is 
registered as a dropzone, and dragging bookmarks to the toolbar gives visual 
feedback that the bookmark is accepted when dropping it there. If it is 
postponed it would probably be better to turn off the personal toolbar as a 
dropzone.

    
    

    
  
I would better wait a week for fixing it... Or is the lesson of Netscape 6.0 as
a non complete, bugfull and featureless final release is already forgotten?

Whith this fix we will win another 0.1% of users!!!

    
    

    
  
Adding helpwanted as per plario's request, though I am going to hold off 
on adding nscatfood, for two reasons:

1. I am not part of netscape, and therefore do not have an interest in nscp 
user satisfaction.
2. IMHO, This is not such a _HUGE_ issue that it is really catfood.
Keywords: helpwanted
Assignee: alecf → ben
Status: ASSIGNED → NEW

    
    

    
  
ben's going to take this, reassigning to him. 

    
    

    
  
This morning's builds had a bug ( bug 80746 ) which may have led to 
a Bugzilla user inadvertantly 
changing this bug from the Assignbed/Accepted status to the New status.  If you 
are the owner of this bug please check to see that it is in the correct Status.  
Thanks.

    
    

    
  
At the very least, the dropzone must be turned off if this feature does not work
properly.  I dragged a bookmark into my personal toolbar on my win98 machine at
home and it *erased* all my personal toolbar bookmarks!!!

    
    

    
  
This bug should be moved to m0.9.2 in favor of fixing bug 78882 for the beta.

    
    

    
  
nav triage: a tough decision, esp for the PM ( :-) ) but lets defer this to post 
m0.9.1. 
Target Milestone: mozilla0.9.1 → mozilla0.9.2

    
    

    
  
Joe said he wanted to do this. 
Assignee: ben → hewitt

    
    

    
  
fixed
Status: NEW → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9.2 → mozilla0.9.1

    
    

    
  
you mean we can now drag links into personal toolbar, or we fixed the problem 
that it drags "null"? 

    
    

    
  
Yes, you can now drag links into the personal toolbar.

    
    

    
  
Is there a bug filled about the removal of the pref ?

    
    

    
  
VERIFIED Fixed with 2001053108 builds on all platforms
Status: RESOLVED → VERIFIED

    
    

    
  
Unable to drag URL to toolbar in 0.9.3
You CAN drag into a FOLDER on the toolbar, however.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Marking mosfreq (14 dups)
Keywords: mostfreq

    
    

    
  
This works fine for me. Please retest.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
I there a bug for DnD to choosed location in a folder on the personal toolbar
(not to the bottom of it)?

Also right-click menu inside a folder to edit/rename/remove etc the bookmark
(works on the personal toolbar bookmark, but not inside a folder) does not exists.

I was surprised since I couldn't find bugs for this major Personal Toolbar
features...

Should I fillthe bugs or there already bugs for it?

    
    

    
  
>I there a bug for DnD to choosed location in a folder on the personal toolbar
>(not to the bottom of it)?

bug 53707, RFE: dragging a link onto bookmarks button should open menu

>Also right-click menu inside a folder to edit/rename/remove etc the bookmark
>(works on the personal toolbar bookmark, but not inside a folder) does not 
>exists.

Bug 50504, Context menu for bookmarks menus

You should be able to find any other related bugs using dependency trees or 
collect buglinks <http://www.squarefree.com/bookmarklets/mozilla.html> on those 
two bugs.

    
    

    
  
Return of......   a BUG !!!!!!!

When I drag a Link into the Personal Toolbar, it disapears !!

I use Mozilla 0.9.8 .
It didn't even works when I install Mozilla after a total deinstall!

    
    

    
  
This apparently still happens for some profiles, probably because of something
that happened using a prior version of the product.  Jens, can you try it in a
new profile and see if that fixes it?  If so, it's probably better to open a new
bug so we can try to figure out what's unique about the failing profile. 
(Elaine King also experiences this problem with current builds.)
Product: Browser → Seamonkey

    
  
Status: RESOLVED → VERIFIED
Keywords: helpwanted

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: