46558 - Stat for permissions to target dir before continuing from setup type dlg

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Paul Wyskoczka]

Build 2000072609 on Linux only

Steps:
1. Download Linux installer from sweetlou
2. Unzip and untar the file
3. Run the installer and accept all the defaults
4. Install to /usr/local/netscape without changing the permissions on the 
folder.
5. The install runs and downloads the xpi files but does not install.


No error message is displayed.  
Change the permission and the browser is installed.

Comment 1

[Samir Gehani]

Changed summary to reflect bug.  This will be easily encountered by the target 
group using a GUI installer on Linux.  Hence, nominating for nsbeta3.

Steve,
Could you document in the README's linux installer instructions that users must 
ensure that they have write permission for the target installation directory 
(default is /usr/local/bin but is changable through the installer's file 
selection dialog) before trying to install?  Thanks.

Comment 2

[Samir Gehani]

Reassigning to moi.

Comment 3

[Paul Wyskoczka]

Release note for Beta2.  Added keyword

Comment 4

[David Krause]

I think we should do more than just document this in a README file.  The
installer should check the directory right after it is selected before anything
else happens.  If it is not writeable a Permission Denied message should be
displayed and the installer should exit.

Comment 5

[Samir Gehani]

Actually David, I think we should ask the user to select another directory 
instead of exiting.  Agree?

Comment 6

[David Krause]

Samir, yes I think that would be more preferable to exiting.

Comment 7

[Ben Bucksch (:BenB)]

Bug 55754 is similar, but a crash.

Comment 8

[Samir Gehani]

*** Bug 49482 has been marked as a duplicate of this bug. ***

Comment 9

[Daniel Veditz [:dveditz]]

Unsetting missed milestones to aid triage queries.

Comment 10

[Daniel Veditz [:dveditz]]

Isn't this one fixed? Last time I tried it I got a dialog box saying I didn't
have write permissions to /usr/local/mozilla

Comment 11

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 12

[Samir Gehani]

Fix checked in.

Comment 13

[Samir Gehani]

Oops, marked wrong bug fixed.  (Bug 54668 was fixed.)  Reopening.  Sorry for the
spam.

Comment 14

[Samir Gehani]

Attachment: Fix: throw up dialog asking user to sleect dir again if s/he doesn't have rwx perms on target dir.

Comment 15

[Samir Gehani]

ssu, please review.
mscott, please super review.

Thanks.

Comment 16

[Samir Gehani]

Attachment: Revised patch per ssu's review.

Comment 17

[Sean Su]

r=ssu d00d'ms

Comment 18

[Alec Flett]

sr=alecf

Comment 19

[Samir Gehani]

Fix checked in.

Comment 20

[Grace Bush]

Samir,

when I choose default (/usr/local/netscape) for which I do not have permission
to install....I am getting two messages...1l- directory does not exist -create
it?  and then 2. error -624  'can't make directory...choose another'  
I question because I was expecting error -626 per patch  vs the -624
Expected?

Comment 21

[Samir Gehani]

E_MKDIR_FAIL == -624 which is correct.  If the directory already existed and the
user didn't have rwx perms and tried to proceed then you would see E_NO_PERMS ==
-626.  

Comment 22

[Grace Bush]

verify 2001040305