46562 - [fix in hand]'display: run-in' disables whole declaration block

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
Navigate to the following testcase.

Actual result:
H2 is black and block-level.

Expected result:
H2 should be green and inline. Only 'display: run-in' should be ignored.

Reproduceable: always

Occurs on:
2000072520 nightly build on Windows 2000
Latest cvs build on Windows 2000

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Testcase

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Proposed patch. This also includes a fix for bug 46547

Comment 3

[Hixie (not reading bugmail)]

Your change results in treating 'display: run-in' the same as 'display:foo' and
'bar:baz', right?

Comment 4

[Pierre Saslawsky]

Marking Invalid. We want to discard the entire declaration block in case of an 
unsupported display type. See bug 2056 (display:run-in), bug 14983 (compact), bug 
18218 (inline-table) and bug 15432.

Comment 5

[Hixie (not reading bugmail)]

Nooo no no no no nooooooooo. :-)

We want to ignore just that property-value pair (that "declaration" in strict
CSS terms). This is very welll defined in the specification. I appologise 
profusely if I ever got across the idea that we had to ignore the entire {...} 
declaration block!

Here is a quote from CSS1:

# For example, assume a CSS1 parser encounters this style sheet: 
# 
# H1 { color: red; font-style: 12pt }
# P { color: blue;  font-vendor: any;  font-variant: small-caps }
# EM EM { font-style: normal }
# 
# The second declaration on the first line has an invalid value '12pt'. The
# second declaration on the second line contains an undefined property 'font-
# vendor'. The CSS1 parser will skip these declarations, reducing the style 
# sheet to: 
# 
# H1 { color: red; }
# P { color: blue;  font-variant: small-caps }
# EM EM { font-style: normal }
#

Comment 6

[Pierre Saslawsky]

Sorry, I thought it was what you asked for in bug 15432 and what Peter had agreed 
with... which surprised me a bit at that time because it's against the normal 
parsing rules.

The patch is easy: just uncomment "aErrorCode = NS_CSS_PARSER_DROP_DECLARATION" 
in nsCSSParser.cpp.

Comment 7

[Hixie (not reading bugmail)]

When you say 'fin in hand'... I assume you are not referring to holding Tux
by the fin, and will thus change it to 'fix in hand'. Of course, I guess you 
really could be holding Tux by the fin, since we do have a life-size Tux in the 
building...

Again, appolgies for not being clear in bug 15432!

Comment 8

[Marc Attinasi]

Approving for nsbeta3

Comment 9

[Pierre Saslawsky]

Fix checked in nsCSSParser.cpp

Comment 10

[Masatoshi Kimura [:emk]]

Verified fixed using 2000080508 nightly on Windows 2000.