46704 - investigate imagelib cache performance

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Warren Harris]

From the footprint meeting 7/26/00:

3) Image Library
  Description: We have anecdotal information that the image memory cache (not 
the network memory cache) is not being hit 
  very often. We also don't know if the size of the cache is bounded and if it a 
memory flush listener.
  Module owner: [e-mail]
  Task owner: [e-mail] (?)
  Status: Syd to work with Pam to analyze image memory cache usage and size 
limits.

Comment 1

[pnunn]

Info I sent out responding to Vidur's email:
<quote>
  In the interest of speeding up the process, here's some initial info: 

  1. The image cache is hit when the default channel load attribute for an image 
is **not**  set 
  to FORCE_VALIDATION, VALIDATE_ALWAYS, FORCE_RELOAD, and 
  INHIBIT_PERSISTANT_CACHING.   When an image container is first created, it is 
set 
  to not use the imgcache. 

  2. Size of cache is bounded to 2M. See IL_SetCacheSize() 
  in ImageManagerImpl::ImageManagerImpl() in mozilla/gfx/src/nsImageManager.cpp 

  3. I don't understand what you mean by a memory flush listener. Send me some 
more 
  info about what you want to investigate and I'll dig out what I can. 
    -p 

  ps. I'm currently looking to see how internal (chrome) images are requested. 
They should get pulled 
  out of the imgcache, but seem to get a force-validation from somewhere that 
removes them from 
  the imgcache. 
<unquote>    
    
    

Comment 2

[Warren Harris]

footprint meeting 8/9/00 status: dougt added a pref but its value is still set 
to 2M. Someone needs to investigate what a good number will be.

Doug: Please update this bug with status.

Comment 3

[Warren Harris]

Marking nsbeta3+ as per the 8/9/00 footprint meeting.

Comment 4

[Syd Logan]

This bug depends on the following bugs:

http://bugzilla.mozilla.org/show_bug.cgi?id=47662 duplicate images in 
necko/imglib caches.
http://bugzilla.mozilla.org/show_bug.cgi?id=49097 only cache chrome, other types 
of images.
http://bugzilla.mozilla.org/show_bug.cgi?id=49098 cache chrome animations

Comment 5

[Syd Logan]

This bug depends on:

http://bugzilla.mozilla.org/show_bug.cgi?id=46704 -- keep chrome images in cache

Comment 6

[Syd Logan]

Attachment: Patch for review

Comment 7

[pnunn]

Patch checked in. This patch only addresses giving
priority to chrome images in the image cache.

-p

Comment 8

[pnunn]

Well....patch was backed out due to a crash.
Syd sent a new patch.

I've tested. I found one more place where chrome images
were being removed from the imgcache. I fixed that and
added an #ifdef we can change if we want to switch
"pinning chrome" on and off.

Tested on linux & nt. 
Will check in asato  (AsSoonAsTreeOpens)
-p

Comment 9

[pnunn]

Attachment: patch of pn changes to syd's patch

Comment 10

[pnunn]

checked in with most recent changes.
-p

Comment 11

[Viswanath Ramachandran]

sorry cannto ahve blanket nsbeta3+ bugs at p3 or below. please
mark this fixed if your work is done.

Comment 12

[pnunn]

syd:
I'm closing this bug, ok. No need for it to be on our
radar. Imgcache issues are handled in other bugs.
-pn