467477 - View Source should linkify xlink:href

Status: RESOLVED FIXED

(Core :: XML, enhancement)

Description

[Jesse Ruderman]

SVG documents use xlink:href for hyperlinks and for many types of resources (e.g. <svg:use>).  View Source should linkify these URLs like it does for hyperlinks and resources in HTML and XHTML documents.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 416860 [details] [diff] [review]
patch

>diff --git a/parser/htmlparser/src/nsViewSourceHTML.cpp b/parser/htmlparser/src/nsViewSourceHTML.cpp
>   PRBool isSrc = !isHref && trimmedAttrName.LowerCaseEqualsLiteral("src");
>+  isSrc |= (mDocType == eXML && trimmedAttrName.EqualsLiteral("xlink:href"));

I'd rather see you add isXLink and return isHref || isSrc || isXLink at the end of the function.

r=mrbkap with that.

Comment 4

[Robert Longson [:longsonr]]

Attachment: address review comments

Comment 5

[Robert Longson [:longsonr]]

checked in http://hg.mozilla.org/mozilla-central/rev/88e7afda452a