471359 - trunk build broken with "libxul.so: hidden symbol `deflate' isn't defined"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Fabien Tassin]

trunk is broken for me since ~ rev 23123.
I traced it to http://hg.mozilla.org/mozilla-central/rev/8eb5a5b83a93
(it's a merge).

This is a regular Ubuntu build, i.e. it has --enable-system-hunspell
--with-system-zlib=/usr --with-system-bz2=/usr

Here is how it fails:

g++  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -g -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions  -fPIC -shared -Wl,-z,defs -Wl,-h,libxul.so -o libxul.so  nsStaticXULComponents.o nsUnicharUtils.o nsCompressedCharMap.o nsBidiUtils.o nsRDFResource.o     -lpthread -Wl,-Bsymbolic-functions  -Wl,-rpath-link,/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/dist/bin -Wl,-rpath-link,/usr/lib  -Wl,--whole-archive ../../embedding/browser/gtk/src/libgtkembedmoz.a ../../toolkit/xre/libxulapp_s.a  ../../staticlib/components/libxpconnect.a ../../staticlib/components/libnecko.a ../../staticlib/components/libuconv.a ../../staticlib/components/libi18n.a ../../staticlib/components/libchardet.a ../../staticlib/components/libjar50.a ../../staticlib/components/libpref.a ../../staticlib/components/libcaps.a ../../staticlib/components/libhtmlpars.a ../../staticlib/components/libimglib2.a ../../staticlib/components/libgklayout.a ../../staticlib/components/libdocshell.a ../../staticlib/components/libembedcomponents.a ../../staticlib/components/libwebbrwsr.a ../../staticlib/components/libnsappshell.a ../../staticlib/components/libtxmgr.a ../../staticlib/components/libchrome.a ../../staticlib/components/libcommandlines.a ../../staticlib/components/libtoolkitcomps.a ../../staticlib/components/libpipboot.a ../../staticlib/components/libpipnss.a ../../staticlib/components/libgkplugin.a ../../staticlib/components/libmozfind.a ../../staticlib/components/libappcomps.a ../../staticlib/components/libunixproxy.a ../../staticlib/components/libxpinstall.a ../../staticlib/components/libjsd.a ../../staticlib/components/libautoconfig.a ../../staticlib/components/libauth.a ../../staticlib/components/libcookie.a ../../staticlib/components/libpermissions.a ../../staticlib/components/libuniversalchardet.a ../../staticlib/components/libcomposer.a ../../staticlib/components/librdf.a ../../staticlib/components/libwindowds.a ../../staticlib/components/libintlapp.a ../../staticlib/components/libfileview.a ../../staticlib/components/libstoragecomps.a ../../staticlib/components/libplaces.a ../../staticlib/components/libtkautocomplete.a ../../staticlib/components/libsatchel.a ../../staticlib/components/libpippki.a ../../staticlib/components/libucvmath.a ../../staticlib/components/libwidget_gtk2.a ../../staticlib/components/libsystem-pref.a ../../staticlib/components/libgkgfxthebes.a ../../staticlib/components/liboji.a ../../staticlib/components/libaccessibility.a ../../staticlib/components/libremoteservice.a ../../staticlib/components/libspellchecker.a ../../staticlib/components/libzipwriter.a ../../staticlib/libxpcom_core.a ../../staticlib/libucvutil_s.a ../../staticlib/libgkgfx.a ../../staticlib/libgfxshared_s.a ../../staticlib/libmozreg_s.a ../../staticlib/libmorkreader_s.a ../../staticlib/libgtkxtbin.a ../../staticlib/libgfxpsshar.a ../../staticlib/libthebes.a ../../staticlib/libjsj.a  -Wl,--no-whole-archive -L../../dist/lib -lsqlite3 -L../../dist/bin -L../../dist/lib  -L../../dist/bin -L../../dist/lib -L../../jpeg -lmozjpeg -L../../modules/libimg/png -lmozpng -L/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/dist/bin -lmozlcms -L/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/dist/bin -lmozjs -L/usr/lib -lssl3 -lsmime3 -lnss3 -lnssutil3 -lcrmf -lcairo -lfreetype -lz -lfontconfig    -lXrender -lcairo -lX11    -L/usr/lib -lz  -lhunspell-1.2   -L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -L//lib -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0    -lX11  -lpangoft2-1.0 -lpango-1.0 -lfreetype -lz -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   -lgtk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lfreetype -lz -lfontconfig -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lgio-2.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -lglib-2.0   -lXt -lgthread-2.0 -lfreetype -lz  -lstartup-notification-1   -lasound -ldl -lm     
../../staticlib/components/libnecko.a(nsHTTPCompressConv.o): In function `nsHTTPCompressConv::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, unsigned int, unsigned int)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:299: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:285: undefined reference to `inflateInit2_'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:311: undefined reference to `inflateEnd'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:199: undefined reference to `inflateInit_'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:213: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:257: undefined reference to `inflateReset'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:261: undefined reference to `inflate'
../../staticlib/components/libnecko.a(nsHTTPCompressConv.o): In function `~nsHTTPCompressConv':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:89: undefined reference to `inflateEnd'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:89: undefined reference to `inflateEnd'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:89: undefined reference to `inflateEnd'
../../staticlib/components/libjar50.a(nsZipArchive.o): In function `nsZipArchive::CopyItemToDisk(unsigned int, unsigned int, PRFileDesc*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1158: undefined reference to `crc32'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1172: undefined reference to `crc32'
../../staticlib/components/libjar50.a(nsZipArchive.o): In function `gZlibInit(z_stream_s*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:507: undefined reference to `inflateInit2_'
../../staticlib/components/libjar50.a(nsZipArchive.o): In function `nsZipArchive::InflateItem(nsZipItem const*, PRFileDesc*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1217: undefined reference to `crc32'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1302: undefined reference to `inflateEnd'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1262: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsZipArchive.cpp:1265: undefined reference to `crc32'
../../staticlib/components/libjar50.a(nsJARInputStream.o): In function `nsJARInputStream::ContinueInflate(char*, unsigned int, unsigned int*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsJARInputStream.cpp:314: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsJARInputStream.cpp:323: undefined reference to `crc32'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsJARInputStream.cpp:328: undefined reference to `inflateEnd'
../../staticlib/components/libjar50.a(nsJARInputStream.o): In function `nsJARInputStream::InitFile(nsZipArchive*, nsZipItem*, PRFileDesc*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/nsJARInputStream.cpp:91: undefined reference to `crc32'
../../staticlib/components/libxpinstall.a(CertReader.o): In function `my_inflate':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/xpinstall/src/CertReader.cpp:101: undefined reference to `inflateInit2_'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/xpinstall/src/CertReader.cpp:110: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/xpinstall/src/CertReader.cpp:113: undefined reference to `inflateEnd'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/xpinstall/src/CertReader.cpp:117: undefined reference to `inflateEnd'
../../staticlib/components/libwidget_gtk2.a(nsWindow.o): In function `SetUserTimeAndStartupIDForActivatedWindow':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1214: undefined reference to `sn_display_new'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1219: undefined reference to `sn_launchee_context_new'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1225: undefined reference to `sn_launchee_context_get_id_has_timestamp'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1235: undefined reference to `sn_launchee_context_setup_window'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1236: undefined reference to `sn_launchee_context_complete'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1238: undefined reference to `sn_launchee_context_unref'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1239: undefined reference to `sn_display_unref'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1230: undefined reference to `sn_launchee_context_get_timestamp'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/widget/src/gtk2/nsWindow.cpp:1221: undefined reference to `sn_display_unref'
../../staticlib/components/libspellchecker.a(mozHunspell.o): In function `mozHunspell::Suggest(unsigned short const*, unsigned short***, unsigned int*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:457: undefined reference to `Hunspell::suggest(char***, char const*)'
../../staticlib/components/libspellchecker.a(mozHunspell.o): In function `mozHunspell::Check(unsigned short const*, int*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:433: undefined reference to `Hunspell::spell(char const*, int*, char**)'
../../staticlib/components/libspellchecker.a(mozHunspell.o): In function `mozHunspell::SetDictionary(unsigned short const*)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:152: undefined reference to `Hunspell::~Hunspell()'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:157: undefined reference to `Hunspell::Hunspell(char const*, char const*, char const*)'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:166: undefined reference to `Hunspell::get_dic_encoding()'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:170: undefined reference to `Hunspell::get_dic_encoding()'
../../staticlib/components/libspellchecker.a(mozHunspell.o): In function `~mozHunspell':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:103: undefined reference to `Hunspell::~Hunspell()'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:103: undefined reference to `Hunspell::~Hunspell()'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.cpp:103: undefined reference to `Hunspell::~Hunspell()'
../../staticlib/components/libzipwriter.a(nsDeflateConverter.o): In function `nsDeflateConverter::OnStopRequest(nsIRequest*, nsISupports*, unsigned int)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:196: undefined reference to `deflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:201: undefined reference to `deflateEnd'
../../staticlib/components/libzipwriter.a(nsDeflateConverter.o): In function `nsDeflateConverter::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, unsigned int, unsigned int)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:166: undefined reference to `deflate'
../../staticlib/components/libzipwriter.a(nsDeflateConverter.o): In function `nsDeflateConverter::Init()':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsDeflateConverter.cpp:82: undefined reference to `deflateInit2_'
../../staticlib/components/libzipwriter.a(nsZipDataStream.o): In function `nsZipDataStream::ProcessData(nsIRequest*, nsISupports*, char*, unsigned int, unsigned int)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsZipDataStream.cpp:184: undefined reference to `crc32'
../../staticlib/components/libzipwriter.a(nsZipDataStream.o): In function `nsZipDataStream::Init(nsZipWriter*, nsIOutputStream*, nsZipHeader*, int)':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libjar/zipwriter/src/nsZipDataStream.cpp:70: undefined reference to `crc32'
../../modules/libimg/png/libmozpng.a(png.o): In function `MOZ_PNG_calc_crc':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/png.c:232: undefined reference to `crc32'
../../modules/libimg/png/libmozpng.a(png.o): In function `MOZ_PNG_reset_crc':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/png.c:206: undefined reference to `crc32'
../../modules/libimg/png/libmozpng.a(png.o): In function `MOZ_PNG_reset_zs':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/png.c:765: undefined reference to `inflateReset'
../../modules/libimg/png/libmozpng.a(pngpread.o): In function `MOZ_PNG_proc_IDAT_data':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngpread.c:949: undefined reference to `inflate'
../../modules/libimg/png/libmozpng.a(pngread.o): In function `MOZ_PNG_cr_read_str':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngread.c:148: undefined reference to `inflateInit_'
../../modules/libimg/png/libmozpng.a(pngread.o): In function `MOZ_PNG_read_dest':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngread.c:1396: undefined reference to `inflateEnd'
../../modules/libimg/png/libmozpng.a(pngread.o): In function `MOZ_PNG_read_init_3':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngread.c:302: undefined reference to `inflateInit_'
../../modules/libimg/png/libmozpng.a(pngrutil.o): In function `MOZ_APNG_prog_read_reset':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:3449: undefined reference to `inflateReset'
../../modules/libimg/png/libmozpng.a(pngrutil.o): In function `MOZ_PNG_decomp_chunk':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:239: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:248: undefined reference to `inflateReset'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:362: undefined reference to `inflateReset'
../../modules/libimg/png/libmozpng.a(pngrutil.o): In function `MOZ_PNG_read_finish_row':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:3147: undefined reference to `inflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngrutil.c:3176: undefined reference to `inflateReset'
../../modules/libimg/png/libmozpng.a(pngwrite.o): In function `MOZ_PNG_write_flush':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwrite.c:973: undefined reference to `deflate'
../../modules/libimg/png/libmozpng.a(pngwrite.o): In function `MOZ_PNG_write_destroy':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwrite.c:1097: undefined reference to `deflateEnd'
../../modules/libimg/png/libmozpng.a(pngwutil.o): In function `MOZ_PNG_write_IHDR':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwutil.c:541: undefined reference to `deflateInit2_'
../../modules/libimg/png/libmozpng.a(pngwutil.o): In function `MOZ_PNG_write_finish_row':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwutil.c:1989: undefined reference to `deflate'
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwutil.c:2017: undefined reference to `deflateReset'
../../modules/libimg/png/libmozpng.a(pngwutil.o): In function `MOZ_PNG_write_filtered_row':
/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/modules/libimg/png/pngwutil.c:2834: undefined reference to `deflate'
/usr/bin/ld: libxul.so: hidden symbol `deflate' isn't defined
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status
make[4]: *** [libxul.so] Error 1
make[4]: Leaving directory `/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla/toolkit/library'
make[3]: *** [libs_tier_toolkit] Error 2
make[3]: Leaving directory `/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla'
make[2]: *** [tier_toolkit] Error 2
make[2]: Leaving directory `/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/src/bzr/build-area/xulrunner-1.9.2-1.9.2~a1~hg20081228r23135+nobinonly/build-tree/mozilla'

Comment 1

[Alexander Sack]

js/ seems to replace the dist/include/system_wrappers directory in the middle of the build with its own system_wrappers (and system headers are missing there - e.g. no zlib.h).

Fix could be to either keep system-headers in sync with main tree or make js/ export to its own directory ... I will attach a patch for the latter.

Comment 2

[Alexander Sack]

Attachment: 1st

make js/ export its system_wrappers to its own directory.

Comment 3

[(not currently active) Ted Mielczarek]

Fallout from bug 467583.

Comment 4

[Alexander Sack]

Comment on attachment 354765 [details] [diff] [review]
1st

ted, can you review this?

Comment 5

[Alexander Sack]

Attachment: still 1st

noisy ... the modules/zlib/standalone/Makefile.in part was not ment to be in there.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 354768 [details] [diff] [review]
still 1st

I'll defer to jimb's opinion.

Comment 7

[Alexander Sack]

Attachment: 1st from right host.

Comment 8

[Alexander Sack]

Comment on attachment 354769 [details] [diff] [review]
1st from right host.

finally uploaded the right file ;) ... thanks!

Comment 9

[Fabien Tassin]

(In reply to comment #8)
> (From update of attachment 354769 [details] [diff] [review])
> finally uploaded the right file ;) ... thanks!

This fixed my build. Thanks!

Comment 10

[Alexander Sack]

bumping importance a bit as this would eventually become a distro blocker (not that 1.9.2 it will enter the distros anytime soon ;))

Comment 11

[Jim Blandy :jimb]

Keeping the js and main list of system wrappers in sync seems like the easiest thing to me.

Comment 12

[Jim Blandy :jimb]

Well, of course, they are kept in sync.

The problem here is that js/src/config/Makefile's export step is regenerating
the wrapped system headers, overwriting the work done by config/Makefile.in. 
This would be okay, as config/system-headers and js/src/config/system-headers
are checked to make sure they are the same --- except that system-headers
includes stuff in #if conditionals, and the two are generated with different
#definitions in scope (as determined by the two configure scripts).

It seems to me that js/src shouldn't be doing its 'config' stuff at all when
it's being used as part of the Mozilla tree.

Comment 13

[Alexander Sack]

(In reply to comment #12)
> It seems to me that js/src shouldn't be doing its 'config' stuff at all when
> it's being used as part of the Mozilla tree.

But is there any reason to not use the patch I provided? For me it sounds sane and a hack to "not overwrite existing system-headers" doesnt read much cleaner to me.

Comment 14

[Alexander Sack]

requesting blocking1.9.2 as it breaks all builds that use system libs (like zlib, etc.).

Comment 15

[(not currently active) Ted Mielczarek]

We need to sort this out, one way or the other.

Comment 16

[Alexander Sack]

Attachment: variant - do not overwrite system_wrappers

I think the other patch is cleaner as it allows js to keep using its own system_headers. Anyway, here a pragmatic patch.

Comment 17

[Jim Blandy :jimb]

Comment on attachment 354769 [details] [diff] [review]
1st from right host.

It's a bummer that this has us produce two sets of system wrappers even though we're sharing the dist directory.  But given that the two wrapper directories are generated based on preprocessor symbol definitions chosen by two separate configure scripts, and neither set of definitions is necessarily a subset of the other, having two wrapper directories might make sense.

If we do this, we might as well allow config/system-headers and js/src/config/system-headers to diverge, since they have no interaction with each other, and serve different code bases --- does that sound right?

Comment 18

[Alexander Sack]

(In reply to comment #17)
> (From update of attachment 354769 [details] [diff] [review])
> It's a bummer that this has us produce two sets of system wrappers even though
> we're sharing the dist directory.  But given that the two wrapper directories
> are generated based on preprocessor symbol definitions chosen by two separate
> configure scripts, and neither set of definitions is necessarily a subset of
> the other, having two wrapper directories might make sense.
> 

thanks. that matches my understanding.

> If we do this, we might as well allow config/system-headers and
> js/src/config/system-headers to diverge, since they have no interaction with
> each other, and serve different code bases --- does that sound right?

yes, I think we should consider to open a bug, like "remove system-headers not used by spidermonkey from js/config/system-headers".

Comment 19

[Jim Blandy :jimb]

(In reply to comment #18)
> yes, I think we should consider to open a bug, like "remove system-headers not
> used by spidermonkey from js/config/system-headers".

I'd like to be CC'd on such a bug.

Comment 21

[(not currently active) Ted Mielczarek]

Comment on attachment 354769 [details] [diff] [review]
1st from right host.

This is needed to fix bug 467271, which is blocking1.9.1+. asac: can you land this on trunk so I can get approval and get it onto 1.9.1?

Comment 22

[Alexander Sack]

pushed: http://hg.mozilla.org/mozilla-central/rev/09a5c40fc8e5

Comment 23

[Alexander Sack]

Comment on attachment 354769 [details] [diff] [review]
1st from right host.

needed on 1.9.1 for bug 467583

Comment 24

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 354769 [details] [diff] [review]
1st from right host.

a191=beltzner

Comment 25

[(not currently active) Ted Mielczarek]

Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/964f002880df

Comment 26

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)