47413 - Dragging InetShortcuts created by IE into Nav doesn't work

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

- create an internet shortcut from IE by dragging a link to the desktop
- drag this shortcut into mozilla's navigator

expected:
- url loads

actual:
- some random chunk of the shortcut file gets put into the url bar and "loaded"

The code is all written to do this the "right" way, I just can't get it to work. 
It all lives in 

mozilla/widget/src/windows/nsClipboard.cpp::FindURLFromLocalFile()

For some reason, the code w/in ResolveShortcut() fails to load the file 
(persistFile->Load() fails) and I have no idea why. The filename is valid, but 
the load still fails. Not being a win32 weenie, I'm at a loss here.

Comment 1

[Mike Pinkerton (not reading bugmail)]

marking helpwanted so some win32 weenie can come save my ass again. futuring.

Comment 2

[sean echevarria]

Attachment: fix for ie url shortcuts

Comment 3

[sean echevarria]

I've attached a patch for this.
Check out the change around line 605 before you do anything with this.  On
Win2k, shortcuts ARE unicode.  I replaced the FindUnicodeFromPlainText with a
call to FindURLFromLocalFile - but you may want to revisit that.
Also set it up so that the buffer is alloc'd rather than a stack buffer - could
change that back but would need to pass in buf size to ResolveShortcut().

Comment 4

[sean echevarria]

Attachment: updated patch - fixes formatting and COM leak

Comment 5

[sean echevarria]

Attachment: yet another update - this better be the last one...

Comment 6

[sean echevarria]

that last patch was to address a file handle leak.
While testing the previous patch, I noticed that I couldn't delete my test inet
shortcut until mozilla had exited.

Comment 7

[Mike Pinkerton (not reading bugmail)]

i'll try to get the patch in (minus the bit about replacing the call to 
FindUnicodeFromPlainText...trust me, that is correct).

I can't tell from looking, but what was my version of ResolveShortcut() (which i 
was copying from 4.x) doing wrong?

Thanks Sean, I really appreciate the help!

Comment 8

[Mike Pinkerton (not reading bugmail)]

adding patch keyword, pulling back to m18 so i don't forget to land it

Comment 9

[Chris Waterson]

a=waterson

Comment 10

[Mike Pinkerton (not reading bugmail)]

thanks again sean, this is checked in.

Comment 11

[Keyser Sose]

Does *NOT* work for me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508


Now it doesnt do anything the link doesnt even show up in the status bar. Reopening.

Comment 12

[Mike Pinkerton (not reading bugmail)]

this works fine for me on 2k. jrgm? do you have a 98 box to test? assigning to
you to get off my radar until we can verify...

Comment 13

[John Morrison]

I tried this (drag IE->desktop, drag desktop->Mozilla) with win2k/ie5, nt4/ie4,
win98se/ie5, win95osr2/ie5, and in each case the URL of the shortcut is loaded.

Comment 14

[John Morrison]

FIXED.

Comment 15

[John Morrison]

verified. (Thanks again, Sean!).