474335 - Multiple "Master Password" requests appear times on session restore, steal focus from each other

Status: RESOLVED DUPLICATE of bug 356097

(Firefox :: General, defect)

Description

[Tim McCormack]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.5) Gecko/2008121623 Ubuntu/8.10 (intrepid) Firefox/3.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.5) Gecko/2008121623 Ubuntu/8.10 (intrepid) Firefox/3.0.5

I use Foxmarks to back up my bookmarks, and it often asks for the Master Password within seconds of startup. That's fine when I'm starting fresh, but I'm almost *always* restoring a saved session instead.

The problem is that the Master Password request is *also* triggered by a password field in one of the pages that loads on restore.

If I've already started typing in the first box, the second box will appear over it and steal focus, which results in half the password in each box.

Reproducible: Sometimes

Steps to Reproduce:
0. Make sure you have an add-on installed that requires password access on startup.
1. Restore a session that includes a login page with stored password.
2. Start typing in the first Master Password request box.
Actual Results:  
Another box appears and steals focus.

Expected Results:  
The new request should wait for the first one to be completed. If the request is canceled, all waiting requests are considered canceled.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

also related: bug 348997

Comment 2

[Tim McCormack]

I don't think this is a dupe of either of those, Gavin. 356097 specifically deals with proxy authentication, and 348997 with HTTP Authentication.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The patch in bug 356097 covers all callers of the PSM master password prompt, which includes both HTTP authentication and the form-field triggered password manager.