47464 - getURLForIndex method in History interface do not work

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Vladimir Strigun]

getURLForIndex with correct parameter thrown a raptorWebShellGetURL exception 
and do nothing.
How to reproduce:
Load 4 pages and try to call method getURLForIndex with correct index (0,1,2,3) 
and note that exception raptorWebShellGetURL thrown.
Suggested reason:
Typematch in file /mozilla/java/webclient/src_moz/HistoryImpl.cpp:305
      wsGetURLForIndexEvent * actionEvent = 
	new wsGetURLForIndexEvent(initContext->sHistory,
				  historyIndex);
If change initContext->sHistory to sHistory in this line, then it will works 
correctly.

Reproduced on Mozilla M16 and Webclient sources from 07.31.2000

Comment 1

[Gervase Markham [:gerv]]

Confirming due to high quality. [e-mail] is the man for this file.

Gerv

Comment 2

[edburns]

I accept

Comment 3

[edburns]

Vladimir's fix does work.  I'll attach a patch for review.

Ed

Comment 4

[edburns]

Attachment: cvs diff -u of fix for this bug, first iteration.

Comment 5

[edburns]

This fix removes gHistory, and makes it so History.getURLForIndex()
works, thanks to [e-mail] (Vladimir Strigun).

M HistoryImpl.cpp
M NativeEventThread.cpp
M WindowControlActionEvents.cpp
M WindowControlImpl.cpp
M WrapperFactoryImpl.cpp
M ns_util.h

HistoryImpl.cpp NativeEventThread.cpp WindowControlActionEvents.cpp 
WindowControlImpl.cpp WrapperFactoryImpl.cpp ns_util.h

Comment 6

[Ashu Kulkarni]

r = ashuk

looks good.

Comment 7

[edburns]

Fix checked in.

Comment 8

[edburns]

Fix checked in.

Comment 9

[Vladimir Strigun]

Mark this bug as verified.
Verifid with Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.1) Gecko/20010910