47519 - show tooltip for href (links), src (images) and name (named anchors)

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect, P3)

Description

[Kathleen :Brade]

The following changes should be made to the statusbar area (based on a review of
the current UI):
 * make the area shorter (to match resize icon on Mac)
 * look at navigator.xul for consistency
 * clear the status text after the user has made a modification (or some other
similar time)

Comment 1

[rubydoo123]

setting to nsbeta3+

Comment 2

[Ryan Cassin]

beppe said she'd like me to take a look at this bug, so I'll reassign to myself 
and fix it.

Comment 3

[Ryan Cassin]

Reassigning to [e-mail] -- I don't have a mac so I can't work on 
this one :\

Comment 4

[Charles Manske]

Simon: can you also make it display link URL like the browser does?
This is related to bug 26250.

Comment 5

[rubydoo123]

this is just going to have to wait, with the timeframe we have and the number of 
bugs on the list, we just can't do them all

Comment 6

[sujay]

also:

1) launch netscape
2) launch composer

look at the bottom pane of window. It says: "Done loading page"

we don't need this string for the composer especially for a blank page.

Comment 7

[Simon Fraser [no longer active]]

-> editor owners

Comment 8

[Syd Logan]

--> kathy, 1.2alpha, nsbeta1+

Comment 9

[Charles Manske]

Can we also include "show URL in the status bar when mouse-over a link" as part 
of this task? I.e., let's use the status bar for something useful!

Comment 10

[Judson Valeski]

We should look at this from a generic notification standpoint. Other Gecko mail
using apps should be able to expose the same type of thing in their own app/UI.

Comment 11

[Kathleen :Brade]

*** Bug 65785 has been marked as a duplicate of this bug. ***

Comment 12

[Kathleen :Brade]

-->glazman per his request

Comment 13

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

accepting bug ; after bug 173319's fix, the status bar is not available any more
so I propose a tooltip. Fix pending.

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Comment 15

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.1

Comment 16

[Kathleen :Brade]

Comment on attachment 103055 [details] [diff] [review]
patch v1.1

r=brade

Comment 17

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.2, carries forward r=brade

Comment 18

[kinmoz]

Comment on attachment 103056 [details] [diff] [review]
patch v1.2, carries forward r=brade

==== I thought that in JS, the 2 expressions below were equivalent? That is an
empty string evaluated to a |false| just like a null did?

+    if (popuptext && popuptext != "") {


sr=[e-mail]

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think this could wait for 1.3alpha.

Comment 20

[Brendan Eich [:brendan]]

kin's right, it's redundant to test

+    if (popuptext && popuptext != "") {

in JS.

This patch is fine 1.3alpha material -- the trunk should open for 1.3alpha on
Friday, or possibly Monday.  Anyone deriving products from the trunk before then
should patch locally.

/be

Comment 21

[[e-mail]]

Attachment: I don't think glazou's patch works in all cases

Attachment 103056 [details] [diff] only checks the innermost element; in the case of (say) the
"The Mozilla Organization" link on the Mozilla home page the text is wrapped in
a <b> so that you need to walk up the tree to find the link, or alternatively
to find an anchor. You probably don't have to walk up in the case of images but
I couldn't think of an easy way to special case them.

Comment 22

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 104634 [details] [diff] [review]
I don't think glazou's patch works in all cases


>+      tooltipText = node.src;
>+    else if (node instanceof Components.interfaces.nsIDOMHTMLAnchorElement)
>+      tooltipText = node.href || node.name;

If you do that instead of .getAttribute("src") and .getAttribute("href"), the
tooltip
will display the local path of an anchor. For instance, if you edit c:\foo.htm
and want
to see the tooltip of <a href="#bar">, it will show file:///c:/foo.htm#bar and
I don't
think it is desireable.

otherwise r=glazman and thanks a lot for detecting this case

Comment 23

[[e-mail]]

Attachment: Fixed glazou's issue

Comment 24

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 105315 [details] [diff] [review]
Fixed glazou's issue

r=glazman

Comment 25

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in (trunk)

Comment 26

[sairuh (rarely reading bugmail)]

when i mouseover a link <a href..>, an image <img src...> or an anchor <a
name..> in composer, a tooltip now appears. vrfy'd fixed with 2003.02.19 on
win2k and mac 10.2.4.