47544 - implement Insert | Line Break (turn it on)

Status: NEW

(SeaMonkey :: Composer, defect, P3)

Description

[Kathleen :Brade]

We need to implement Insert | Line Break

Comment 1

[Karl Ove Hufthammer]

Why? When you press Enter you get a line break anyway, *not* a new paragraph 
(which is a really, really, *really* stupid feature IMNSHO).

Comment 2

[Kathleen :Brade]

*** Bug 48678 has been marked as a duplicate of this bug. ***

Comment 3

[Charles Manske]

I had bug 48678, so I guess this is mine.

Comment 4

[Charles Manske]

Attachment: Fix for 47544 and 47545

Comment 5

[Charles Manske]

Note: Bugs 47544 and 47545 are very similar. Stubs for nsInsertBreak and
nsInsertBreakAll already existed in ComposerCommands.js. Diff shows the
implementation added (not enough context in diff: nsInsertBreak is first in diff.)

Comment 6

[Kathleen :Brade]

r=brade (though I do *not* understand why we'd want this feature right now since 
pressing return inserts a <br>; yes, I know that I filed this bug...)

My preference would be to *not* add this item to the Composer menu until pressing 
return/enter does a different function (like inserting a paragraph).

Comment 7

[Charles Manske]

I agree with Kathy, we don't really need this.
I'll checkin the suggested code but comment-out the menuitem for "Line Break"
Setting bug to future so we remember the issue after switching Enter key usage.

Comment 8

[Charles Manske]

Clearing status whiteboard

Comment 9

[Charles Manske]

I checked in the "commented out" XUL code as described.
"nsInsertBreak" command (in ComposerCommands.js) was implemented.

Comment 10

[Charles Manske]

setting milestone to match when it was checked in.

Comment 11

[sujay]

I do not see this implemented in 4/4 build on windows.

Comment 12

[Kathleen :Brade]

move this bug to Future; we'll turn it on someday

Comment 13

[Syd Logan]

spam composer change

Comment 14

[rubydoo123]

removing myself from the cc list

Comment 15

[Tony Mechelynck [:tonymec]]

No comment in six years (and a "removing myself" at that... the previous one was six months before). Is this still "Future" or shall we move it to Never i.e. WONTFIX? Or, on the contrary, target it for Sm2?

Comment 16

[Tony Mechelynck [:tonymec]]

Resetting A+QA after long inactivity