Closed Bug 475711 Opened 16 years ago Closed 16 years ago

"Restore Default Set" doesn't handle dynamic nodes correctly

Categories

(Toolkit :: Toolbars and Toolbar Customization, defect)

Product:
Toolkit
Component:
Toolbars and Toolbar Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression, verified1.9.1)

Attachments

(1 file, 1 obsolete file)

Addressed review comments
1.64 KB, patch
Gavin
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
In bug 407725 I forgot that separators, springs and spacers should be removed from the toolbar and not moved back to the palette.
Attached patch Proposed patch (obsolete) — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #359254 -
        Flags: review?(gavin.sharp)

    
    

    
  
Comment on attachment 359254 [details] [diff] [review]
Proposed patch

I'd add some brackets and use a temporary for localName, but r=me either way.

        Attachment #359254 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  


  

        Attachment #359937 -
        Flags: review?(gavin.sharp)

        Attachment #359937 -
        Flags: review?(gavin.sharp) → review+
Component: Toolbars → Toolbars and Toolbar Customization
Product: Firefox → Toolkit
QA Contact: toolbars → toolbars
Version: unspecified → 1.9.1 Branch

    
    

    
  
We should fix this on the branch as well.

    
    

    
  
Pushed changeset caa042e73aaa to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 359937 [details] [diff] [review]
Addressed review comments

Safe regression fix.

        Attachment #359937 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 359937 [details] [diff] [review]
Addressed review comments

a191=beltzner

        Attachment #359937 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Can we get a test for this as well? I approved it to get past the regression, but it seems testable.

    
    

    
  
Neil, when are you going to land this on 1.9.1?

    
  
Blocks: 413385

    
  
Keywords: checkin-needed

        Attachment #359254 -
        Attachment is obsolete: true
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Version: 1.9.1 Branch → Trunk

    
    

    
  
verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090505 Minefield/3.6a1pre ID:20090505030940

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090505 Shiretoko/3.5b5pre ID:20090505030932
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: