4763 - International date format for the message thread pane

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[nhottanscp]

International date/time format for the message thread pane for M5.

Comment 1

[nhottanscp]

Reassigning to putterman, please reassign if necessary.
Use nsIDateTimeFormat
(see a document at http://www.mozilla.org/projects/intl/date-time-format.html).
We agreed to use always application locale (i.e. single date format through one
app). Application locale can be available through
nsILocaleFactory::GetApplicationLocale.

Comment 2

[scottputterman]

Chris,

I think we had talked about this before about having a Date Literal that the
tree widget could display correctly.

Comment 3

[scottputterman]

Moving to M6.

Comment 4

[scottputterman]

I'm trying to use this, but it looks like your nsILocaleFactory, which I'm
trying to create so I can call GetApplicationLocale, is always returning me an
nsILocale rather than an nsILocaleFactory.  Therefore I crash when I try to call
nsILocaleFactory::GetApplicationLocale.

Comment 5

[scottputterman]

Also, when I do:

	rv = nsComponentManager::CreateInstance(kDateTimeFormatCID, NULL,
		nsIDateTimeFormat::GetIID(), getter_AddRefs(mDateTimeFormat));
I always get back a null pointer so I can't use this.

Comment 6

[scottputterman]

You also might want to add
NS_DEFINE_STATIC_IID_ACCESSOR(NS_ILOCALEFACTORY_IID)
 to nsILocaleFactory.h

Comment 7

[nhottanscp]

The date/time interface does not have GetIID, please use the following for now.
static NS_DEFINE_IID(kIDateTimeFormatIID, NS_IDATETIMEFORMAT_IID);

Comment 8

[nhottanscp]

Adding [e-mail] to cc, he owns nsILocaleFactory.

Comment 9

[nhottanscp]

Regarding the problem of nsILocaleFactory::GetApplicationLocale, it is also used
for the message sorting. I am not sure why it causes the problem for date/time
in particular.
It may be related that there was a windows dll loading problem (#5564) but I
think that has been fixed.

Comment 10

[scottputterman]

It looks like I might have been using it wrong.  There's probably not a problem.
I was using CreateInstance instead of FindFactory.  I'll try that out tomorrow.
There may not be any problem with the nsIDateFormat either.  I'll update this
bug when I try these out.

Comment 11

[scottputterman]

OK, I'm able to get all of these objects now.  I'll update this bug if I have
any problems using the date/time formater.

Also, I think it would be useful to implement GetIID() for these classes.  I was
trying to use an nsCOMPtr with some of these and I couldn't because of this.

Comment 12

[scottputterman]

OK, everything seems to be working, at least for my application locale.  I'll
check this in when the tree opens.

Comment 13

[nhottanscp]

I will implement GetIID() for M7. These classes are bit old (written in 1/99).

Comment 14

[scottputterman]

This isn't working on my linux build.  It can't find the factory and it can't
create a DateTimeFormat.  Is there a registering problem with this dll on Linux?
I can't check this code in until it works there.

Comment 15

[nhottanscp]

My test program (LocaleSelfTest.cpp) is also failing for creating
nsILocaleFactory.
Tague, could you take a look at this?
Scott, does sorting have the same problem?

Comment 16

[scottputterman]

Sorting seems to work as well as it ever did.  I can probably check this code
in, but it will mean that the date column will stop showing up on linux until
this is fixed which would be a pretty high priority.  I also don't know if this
works on the Mac.

Comment 17

[scottputterman]

Getting rid of the #if 0 made it work on Linux.  Is there a reason why we
shouldn't check it in?  I can check it in but I'd like to know what I might be
breaking by doing that.

Comment 18

[scottputterman]

I checked in my fixes.  Right now there will be no date string in Linux until we
fix the registration problems.  But you can test this on Windows.

Comment 19

[tague]

this should be fixed on linux and should be working on Mac once I get checkin
approval.

Comment 20

[Katsuhiko Momoi]

marina, please verify if this fix is working

Comment 21

[marina]

I verified it on the French NT 4.0, it is working ,the data is in the
\\babel\babel_docs\tests\Mail-News\tools\sort\data7.txt