47813 - Mail and news preferences dialog improperly painted

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Devoti Paolo]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m18) Gecko/20000804
BuildID:    2000080420

See the attachment

Reproducible: Always
Steps to Reproduce:
1.Close all the mozilla related apps
2.open mozilla browser
3.edit->preferences
4.click on "mail and newsgroups"

Actual Results:  the attached image

Expected Results:  proper display

Comment 1

[Devoti Paolo]

Attachment: bogous dialog

Comment 2

[Asa Dotzler [:asa]]

confirmed with 080620 win32 M18 mozilla build on win98

Comment 3

[David M. Karr]

It might be useful to know that once this dialog comes up for the first time, if
you use the mouse to drag the bottom of the frame a very small amount, the
display "fixes" itself.  When you bring up this dialog again, it displays correctly.

Comment 4

[sairuh (rarely reading bugmail)]

i see this on both linux and winNT, using either the modern or classic skin. for
some reason, i don't see this on Mac. tested using 2000.10.13.09-n6 commercial
branch bits.

jrgm, should this go to one of the xp toolkit/widget people? or, would it
perchance be a mailnews frontend issue?

Comment 5

[John Morrison]

(Is there not a duplicate of this bug somewhere?)

This is a box-to-block layout, evaughan type of bug. However, there is
nothing that will be done to cure this defect before RTM; it would be
way to invasive at this point, solely to repair one known dialog in
the shipping product.

(Basically, the length of that text, given the default width of the
pref panel, is triggering a layout bug; when that text line wraps, it
should reflow all boxes, which should update the painted appearance
onscreen.)


There is something that can be done to workaround this bug (at least
for English localizations) -- Change the text:

  "Note: For this setting to take effect, you will need to exit
   and then restart Mail."

to something shorter like

  "For this setting to take effect, you will need to restart Mail."

Comment 6

[John Morrison]

Scratch the above. The right fix for this is to set a 'min-height:40px' for 
#classic and #wide (the 3pane images) in pref-mailnews.css for each of the 
skins. (I realized it was these images arriving that was triggering the faulty
reflow, not the wrapped text -- so pre-reserve the height for these images).

This is such a cheap fix for a really ugly and highly visible problem that I 
will propose this for RTM, but someone from mailnews is going to have advocate
for this fix (and do the checkin magic).

Comment 7

[sairuh (rarely reading bugmail)]

bugzilla is having a headache. trying again to move over to mailnews frontend...

Comment 8

[scottputterman]

It's too late for Netscape RTM. But, if you have patch, attach it so I can
review it and we can get it in on the trunk.

Comment 9

[John Morrison]

Attachment: patch pref-mailnews.css to pre-allocate height for incoming images (avoid the reflow)

Comment 10

[John Morrison]

There's the patch. It's just the same one-line change times two images times 
four skins. I chose 32px because that is the height of the image (in either 
skin). Fixes the problem for me, and it really is a simple workaround.

CC: evaughan, if he wants to look at this, and even if this is checked in,
we should probably hang on to this bug because the underlying box layout 
problem still exists, which this dialog demonstrates well.

Comment 11

[John Morrison]

Duh. Really cc: evaughan this time.

Comment 12

[scottputterman]

this makes it work for me as well. r=scottip. You might want to get approval
from someone with more css knowledge, but it looks fine.

Comment 13

[sairuh (rarely reading bugmail)]

*** Bug 59154 has been marked as a duplicate of this bug. ***

Comment 14

[scottputterman]

reassigning to sspitzer

Comment 15

[lchiang]

does this also happen on the Mac?  may be good to take the patch on this.

Comment 16

[(not reading, please use [e-mail] instead)]

hewitt, can you review this patch?

Comment 17

[Boris Zbarsky [:bzbarsky]]

nominating for mozilla0.9.  This happens on all platforms, so setting os -> all.

Comment 18

[Boris Zbarsky [:bzbarsky]]

*** Bug 68657 has been marked as a duplicate of this bug. ***

Comment 19

[Boris Zbarsky [:bzbarsky]]

*** Bug 46823 has been marked as a duplicate of this bug. ***

Comment 20

[sairuh (rarely reading bugmail)]

joe, could you review? thx!

Comment 21

[Joe Hewitt (gone)]

Glad to see this fixed, it's been annoying me for a long time.  sr=hewitt

Comment 22

[Håkan Waara]

This has a patch, and a sr= -- can someone check it in too?

Comment 23

[Blake Ross]

Patch checked in per request from Asa.

Comment 24

[laurel]

OK with mar16 commercial trunk builds, linux rh6.0, win98, mac OS 9.0

Comment 25

[R.K.Aa.]

This is not fixed - never was. It just improved, but the pref for Mail and
Newsgroups still look bad on a current CVS linux build.

Comment 26

[R.K.Aa.]

Attachment: today's screenshot [45920 byte .jpg]

Comment 27

[Devoti Paolo]

Verified bad with win 98 2001041212.
It's as displayed in the 04/19/01 attachment

Comment 28

[John Morrison]

Hey, it looks just like 
this http://bugzilla.mozilla.org/showattachment.cgi?attach_id=28155

Already filed separately (not quite the same bug).

Re-resolving fixed/verified.

Comment 29

[John Morrison]

Other bug is bug 72535.