480128 - XPT linking does not apply when packaging for wince (.cab)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Frederic Plourde (:fred23)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6
Build Identifier: from fennec-1.0a2pre.en-US on

This is a followup bug based on XPTlinking patches proposed in Bug 469873. The patches provided 'mobile' with XPTlinking for | make package | and | make deb | targets, but it's been notices that it did not apply to cab packaging on the wince side.

Reproducible: Always

Steps to Reproduce:
1. Install all the 'Windows Mobile' prerequisites listed in: https://wiki.mozilla.org/Mobile/Build/Windows_Mobile_PrepForBuild

2. On WinXP (or VMWare partition of it on a another platform), compile mozilla-central, following steps at : https://wiki.mozilla.org/Mobile/Build/Windows_Mobile_BuildingIt

3. When build completes successfully, goto the obj-dir mobile directory, e.g. mozilla-central/objdir-wm6-rel-vs8/mobile

4. Package mobile by typing: make package

5. cd dist/fennec/xulrunner/components

6. notice there are many XPT files instead of a single xulrunner.xpt bundle.
(alternatively, you can look into the dist/fennec<*>.cab archive and notice the same thing)


Expected Results:  
We expect a single xulrunner.xpt bundle created in the dist/fennec/xulrunner/components folder

Comment 1

[(not currently active) Ted Mielczarek]

If this is true then I'm probably going to r- your patch on the other bug anyway, FWIW.

Comment 2

[Frederic Plourde (:fred23)]

wait, I'm investigating it.
It seems that XPT linking works fine for wince (on the xulrunner side). It's something on the mobile side (maybe the NO_PKG_FILES define that gets screwed up) where lies the problem... I'm almost throught with it.

Comment 3

[Frederic Plourde (:fred23)]

I've had extensive discussions with wolfe about that topic and, by applying its 2 patches in Bug 476733, along with the ones in Bug 469873, the present wince-related issue is practically resolved.

All that's left to do is to choose whether or not we should add a |CAB| target for wince that'd be specific to .cab packaging, while keeping the | make package | behavior to making a tar.gz package (which I need for XPT linking)