48243 - event.shiftKey not set in event passed to oncommand handler

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Bill Law]

To fix bug 21137 we need to be able to detect whether the shift key is depressed 
when the Reload button is clicked.

This should be possible by examining the event.shiftKey property on the event 
passed to the <broadcaster>'s oncommand handler.  However, that property is not 
set properly and is always "false."

I suspect other properties are similarly broken.

Comment 1

[Bill Law]

Marking as nsbeta3 since this blocks the nsbeta3+ bug 21137.

Comment 2

[Ben Bucksch (:BenB)]

FYI: It works fine in Mailnews: Open a new msg in the not-default editor by
activating SHIFT+(New Msg-button).

Comment 3

[David Hyatt]

Should be +.  This is bad.

Comment 4

[Bill Law]

Ben, that's probably because Mailnews is using an onclick handler, or not using 
a <broadcaster>, or something like that.  I think this problem only appears in a 
somewhat limited set of circumstances.

Comment 5

[Peter Trudelle]

reassigning to saari as nsbeta3+, P3 for M18

Comment 6

[Bill Law]

Please note that this is a blocker for bug 21137.  I'm not sure that one's a P3 
and I'd hate to see the fix for that one go to waste...

Comment 7

[saari (gone)]

clearing nsbeta3+ for review

Comment 8

[Peter Trudelle]

nsbeta3+, P3 for M18, since this is the only way to get the reload-from-net feature.

Comment 9

[saari (gone)]

Fixed

Comment 10

[blanca]

Bill - I was going to verify fix by loading a local page, edit the page and
reload it with the shift key.  Would this be sufficient?

Comment 11

[Bill Law]

No, unfortunately it is not that simple.  A local file will be verified using
the timestamp on the file.  You need to either have a web server that you can
monitor (and the provides the appropriate headers that indicate that the file
has not changed even though it has).  You can do it with local files but you
have to jigger the file timestamps.  Bug 48275 explains how to do that.