48311 - Filepicker does not display proper file list

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Dan Rosen]

Spun off of 46658 [nsbeta3+], the XUL filepicker does not display the right
files according to the selected filter. See gabriel's comments in 46658. bryner,
you seem to be handling a lot of filepicker stuff, is this up your alley?

Comment 1

[Dan Rosen]

nominating nsbeta3, adding gabriel to cc.

Comment 2

[gabriel]

Thanks :-)

Comment 3

[Peter Trudelle]

nsbeta3+

Comment 4

[gabriel]

nsFileSpecWithUIImpl.cpp#211 looks like a likely candidate...

Comment 5

[gabriel]

And also sections of editor/base/nsEditorShell.cpp.

(I did a search for *.html; )

Comment 6

[gabriel]

And also, in xpfe/components/filepicker/res/locale/en-US/filepicker.properties

all files should only be (*) for unix systems; for windows it should still be
(*.*)

Comment 7

[sairuh (rarely reading bugmail)]

over to me...

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 49093 has been marked as a duplicate of this bug. ***

Comment 9

[Dan Rosen]

gabriel: my initial confusion regarding the * vs. *.* issue was that
filepicker.properties is retarded, in that it seems to localize but not xp-ize.
the reason that * simply works is because on windows and mac, the native
filepicker is used and the xp code (including filepicker.properties) is not.

also: ouch! nsFileSpecWithUIImpl.cpp looks painfully obsolete (i'm almost
certain that this is/should be taken care of in xul/xbl), and i fear it might be
still used. hyatt would know for sure whether that file could be gutted or
tossed...

Comment 10

[Peter Trudelle]

P2

Comment 11

[Brian Ryner (not reading)]

Checked in fix.

Comment 12

[sairuh (rarely reading bugmail)]

cool, works now. vrfy'd using linux comm 2000.08.22.08.