494718 - Need to add individual .xpts to removed-files.in for Linux

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Phil Ringnalda (:philor)]

Apparently sometime after I stopped really paying attention to bug 469873, it suddenly started actually working (for Linux, not yet at least for OS X), which means that for a month now on c-c+m-c we've been shipping new interfaces (if any) in thunderbird.xpt without telling the updater to remove the old interfaces from the individual files.

It's not on 1.9.1 yet, but blocking+ since it already has a1.9.1.

Comment 1

[Phil Ringnalda (:philor)]

Ulp, and need to get the tiny little bit for 1.8, removing thunderbird.xpt for downgraders, in right bloody now, before the freeze for the last Tb2 in who knows how long.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix for Tb2

I *so* didn't want to ever touch this branch again, but upgrade-downgrade is just too common, and this is our one chance to fix them up (which only happens when they do whatever->Tb3->untar Tb2 over the top->updater to install Tb2.next, but that's all we can do).

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Fix for c-c+m-c

This is the combination of *.xpt from 3.1a1pre from 2009-04-23 (just before linking XPTs started there), current 3.0b3pre, and 2.0.0.21, minus the wallet files (even though I really wanted to remove them again out of spite), so once bug 469873 lands on 1.9.1, we just need to take off that ifdef.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 379491 [details] [diff] [review]
Fix for Tb2

As discussed on irc, my only thought is that we may want to just apply this to Mac as well just in case later on it does get added and we forget.

r=Standard8 either way.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fix for Tb2, v2

Agreed, it doesn't hurt anything to "remove" something that isn't there, and it's impossible to guess when we might need to.

Clock's ticking for approval, though, since the code freeze is tomorrow, making today my last day with time enough to watch the slothful 1.8 tree.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 379585 [details] [diff] [review]
Fix for Tb2, v2

a=dmose

Comment 7

[Phil Ringnalda (:philor)]

mail/installer/removed-files.in 1.1.2.22

Comment 8

[Phil Ringnalda (:philor)]

http://build.mozillamessaging.com/mercurial/comm-central/rev/c4d832059656

Comment 9

[Serge Gautherie (:sgautherie)]

Is this a TB only issue, or should SM (and/or Calendar) check and port these fixes too?

Comment 10

[Mark Banner (:standard8)]

SM has its own packaging file on linux so that shouldn't have changed. Calendar doesn't so that may need a fix as well. All you need to do is see if they have one xpt where they had several before.

Comment 11

[Phil Ringnalda (:philor)]

Working, but a touch too late: the right way to verify this would have been to update from a 20090423 build to a 20090527 build, verify that you had both thunderbird.xpt and the individuals, then update that to 20090528 and verify that the individual ones went away, but since this was already preventing us from even starting, the 27->28 (or any nightly update other than starting from scratch with something after 0423) wasn't actually possible. 20090423 -> 20090528, however, works fine and clears out the xpts.

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Marking verified for 1.8.1.22. Thanks for looking at this, Phil.