49479 - [pagedown] on last page and [end] in xul tree widget don't select the last item.

Status: VERIFIED FIXED

(Core :: XBL, defect, P4)

Description

[Peter "jag" Annema]

Go to some valid file:///, click an item and press the end key. It won't select
the last item. Same for pagedown when you're on the last page. The code which
tries to get the last child
(this.getElementsByTagName("treechildren")[0].lastChild) seems to select an item
which seemed to have a template rule in it. I'll see if I can get some more
information on this.
I'll attaching a patch which fixes this by using getRowCount and cleans up some
other scrolling issues.

Comment 1

[Peter "jag" Annema]

Attachment: [patch] fix end and pagedown selection/scrolling (and \t -> spaces, yell at me if it makes you feel better)

Comment 2

[Peter "jag" Annema]

Adding a few keywords.

Comment 3

[David Hyatt]

Cool.  I'll try to get this reviewed and into the tree soon.  Thanks Peter!

Comment 4

[Peter Trudelle]

nsbeta3+, P4 for M18, ->dr, please have hyatt review and apply.

Comment 5

[Dan Rosen]

yoink!

Comment 6

[Dan Rosen]

checked in jag's fix

Comment 7

[John Morrison]

verified fixed, home/end/pgdn/pgup do scroll and then selection the current row.
mac/linux/win32 2000090308