497400 - MailNews toolbar delete button wrongly styled (CSS typos)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: fix for case 1

The MailNews toolbar delete button is wrongly styled due to wrong CSS (both in Classic and Modern):

Case 1: Switch to small icons. You'll see a part of the normal icon.

Case 2: Open the Customize Toolbar dialog and drag the delete button from the toolbar to the dialog. You'll see an icon that looks like the one used for Reload (or like http://mxr.mozilla.org/comm-central/source/suite/themes/classic/icon.png).

The attached patch fixes the first case. I don't know what the reason for the second case is. Philip (CC'ing you since you worked on Customizable Toolbars)?

Comment 1

[Philip Chee]

> +toolbar[iconsize="small"] #button-junk > #junk-deck > .toolbarbutton-1 {}
> +toolbar[iconsize="small"] #button-delete > #delete-deck > .toolbarbutton-1 {}

This will be fixed in Bug 491676.

> Case 2: Open the Customize Toolbar dialog and drag the delete button from the

This will be fixed in Bug 491676.

Which reminds me I really need to start working on that (unless you want to take that part of the bug.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #1)
> > +toolbar[iconsize="small"] #button-junk > #junk-deck > .toolbarbutton-1 {}
> > +toolbar[iconsize="small"] #button-delete > #delete-deck > .toolbarbutton-1 {}
> 
> This will be fixed in Bug 491676.

OK, but... (for your consideration)
- the rules for the delete button are included in the first patch for that bug but not in your (as of now) last one
- none of the patches over there remove the superfluous commas after rect(0
- none of the patches over there correct the rules for small icons in the Modern theme (which are commented out, but if we don't correct those it looks like they would apply as-is)

> > Case 2: Open the Customize Toolbar dialog and drag the delete button from the
> 
> This will be fixed in Bug 491676.
> 
> Which reminds me I really need to start working on that (unless you want to
> take that part of the bug.

No, you're already on it (with reviews). I just couldn't link that bug to the problems I saw.

Comment 3

[Philip Chee]

> - the rules for the delete button are included in the first patch for that bug
> but not in your (as of now) last one
Neil wants to fix the source of the problems and not to wallpaper over each instance.

- none of the patches over there remove the superfluous commas after rect(0
This part of this bug is still valid!

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: typo fix

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Attachment: updated typo fix [Checkin: Comment 6]

New patch since the patch from bug 491676 was just checked in.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 383113 [details] [diff] [review]
updated typo fix
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/ad8a9df00959