49975 - editor does not regain focus after dialog is dismissed.

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Tracy Walker [:tracy]]

windows 2000-08-23-06-m18
linux 2000-08-23-06-m18

cannot use tool bar functions; spell check (bug 49463) image, hline, table, 
link, anchor.  clicking on any of these elicits no activity.

Comment 1

[leger]

Putting on [dogfood+] radar.

Comment 2

[rubydoo123]

I can't duplicate this on win98, there are various string changes related to DOM 
and JS, that may be causing this, cc jst to see if maybe his checkin could have 
affected this

Comment 3

[rubydoo123]

marking this wfm -- SUjay can you try this on linux and mac 

Comment 4

[rubydoo123]

just saw leger's Daily Qa update -- is this in classic only? If so, then there 
is a problem with something ben or hangas may know about

Comment 5

[Tracy Walker [:tracy]]

works fin on todays build:

Windows 2000-08-24-06-M18
Linux 2000-08-24-06-M18

Comment 6

[Tracy Walker [:tracy]]

this appears to be happening in classic skin only on Linux and Windows
Windows 2000-08-25-06-m18
Linux 2000-08-25-06-m18

Comment 7

[rubydoo123]

if it's in a specific skin, then this issue needs to go to skins group -- if it
happens across all skins, then it should go to editor group

Comment 8

[Blake Ross]

The component for the skins group is Themes, not Skinability...

Comment 9

[Paul Wyskoczka]

Update QA Contact to [e-mail]

Comment 10

[Tracy Walker [:tracy]]

seen today on mac build classic skin: 2000-08-30-04-m18

no icons in personal tool bar.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

worksforme, w2k. 

I fixed the personal toolbar problem earlier tonight. 

Comment 12

[Patty Mac]

Windows (Build:2000082408M18)-- This is fixed.
Linux (Build: 2000082508M18)--Not fixed yet.
Mac (Build: 2000082504M18)--not fixed yet.

Comment 13

[Patty Mac]

Since today's build (2000083108M18) usually get crashes, so I verified
this bug in the early build.

Comment 14

[Tracy Walker [:tracy]]

seeing this on mac only
commercial build 2000-09-01-04-m18

reopening and changing platform to just mac

Comment 15

[verah (gone)]

Nav triage team: [nsbeta3+]

Comment 16

[verah (gone)]

Nav triage team: We take it back... per Bijal, this might be dogfood for 
Composer but nsbeta3- for the project as a whole.

Comment 17

[bijals (gone)]

Beth - Is this required for Composer?

Comment 18

[rubydoo123]

yes, this is required, toolbars must work. a good test on this is if you swap 
skins, close the and reopen, then check toolbar -- there was an issue about 
needing to do that

Comment 19

[Simon Fraser [no longer active]]

What is this bug about? Please include a reproducible test case.

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

this does actually work. the content area of the editor has to have focus, 
however. It tends to lose focus very easily on mac (when you dismiss a dialog 
like insert image, focus to the content area is gone, and needs to be given 
back.. this is done automatically on windows). 

this appears to be a mac specific focus issue with editor. not sure really who 
should get this, but giving to trudelle. 

Comment 21

[Peter Trudelle]

->danm for M18, cc joki & saari.  P1 critical dogfood?  I don't think so.
P3/Normal, nsbeta3+, removing dogfood+ for reconsideration.  This is just an
inconvenience, with a trivial workaround, should not keep any contributors from
using the product.
QA -> jrgm

Comment 22

[leger]

Setting to [dogfood-]

Comment 23

[Tracy Walker [:tracy]]

works fine on mac build 2000-09-06-04-M18

Comment 24

[John Morrison]

Reopening. This does not work for me with 2000090604 on three different macs
(8.6 and 9.0), in either modern or classic skin. 

If you bring up a dialog (e.g. Table, Link, ...) and dismiss it focus is not 
returned to the document. Without focus in the document, you cannot relaunch 
any of the six right-most dialogs. Workaround is to manually reset focus in 
the document after you dismiss a dialog. 

This also does not work (for either skin) on linux with 2000090608. However, 
windows correctly returns the focus to the document when a dialog is dismissed.

Comment 25

[Peter Trudelle]

->saari, cc pinkerton and pavlov for possible platform-specific fixes before
saari gets back from vacation.

Comment 26

[Tracy Walker [:tracy]]

still seeing on mac modern commercial build: 2000-09-12-04-M18

toolbar functions not working....workaround by using menu insert

Comment 27

[saari (gone)]

The bloody toolbar buttons are taking focus again. I'm hunting for the resposible 
parties/changes.

Comment 28

[Tracy Walker [:tracy]]

mac commercial build with modern skin: 2000-09-14-08-M18

not able to use menu | insert options as workaround

changing to smoketest blocker.

Comment 29

[Jon Granrose]

who's working on this?  I'm holding the commercial tree for it.

Comment 30

[Chris McAfee]

saari has a fix in his tree, we are testing it now.

Comment 31

[Peter Trudelle]

->p2

Comment 32

[saari (gone)]

Fixed

Comment 33

[John Morrison]

verified fixed, just to put this bug out of its misery. This works in the
Modern skin for mac and win32 20000915nn builds (I can't try the Classic skin
on mac/win32 because of bug 52822).

However, this does not work for Modern/Classic on Linux 2000091721. I am
filing a separate bug for that.

Comment 34

[John Morrison]

Removing smoketest/blocker, should this ever be reopened.