500657 - open message from Search Messages results does not work well

Status: VERIFIED FIXED

(MailNews Core :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

open message from Search Messages results is odd. 

1. create search that hits on messages in a variety of folders (eg trash and inbox) and message state (read and unread)
2. attempt to open messages via double click or Open

a) worst case is message doesn't open - SA message window outline appears briefly then immediately disappears. so far I can only reproduce this for a message in trash folder
b) i could swear in my initial attempt to open an unread message, that the message status did not change to read. but I was not able to reproduce

nothing in error console

Comment 1

[Wayne Mery (:wsmwk)]

> a) worst case is message doesn't open - SA message window outline appears
> briefly then immediately disappears. so far I can only reproduce this for a
> message in trash folder

did a larger test. consistently can't open messages in trash folder from Search Messages

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Bug 467768 will either fix this or make it much easier to fix.

Comment 3

[Rain [:rain1] (inactive)]

Yeah, the db view wrapper seems to be acting up. Taking this.

Comment 5

[Joe Sabash [:JoeS1]]

Not just trash folder for me.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090628 Lightning/1.0pre Shredder/3.0b3pre ID:20090628031440

I have search results that include 2 different inboxs, rss feeds.
None of which can be opened in a new tab or a new window.

Comment 6

[Rain [:rain1] (inactive)]

Attachment: [checked in] patch to fix opening messages from a gloda search tab

(patch applies over the one from bug 467768)

The main problem is that we don't have any _underlyingFolders, so we do a null dereference there. I'd write a Mozmill test for this, but I'm not sure if it's possible to write one currently. Feel free to r- if it is.

I've also fixed a problem with opening search results in an existing window and the annoying double URL load.

Comment 7

[Rain [:rain1] (inactive)]

Ew -- just noticed the trailing whitespace -- fixed locally.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 385649 [details] [diff] [review]
[checked in] patch to fix opening messages from a gloda search tab

Please land this now and we'll worry about the unit tests after... the breakage on this is bad enough that we do not want this in a(nother) nightly.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Also, don't mark this bug fixed, as Wayne's problem was actually opening things from the search window (control-shift-f), which is actually broken in a slightly different way from bug 467768. (tabmail is referenced in a window where there is no tabmail.)

Comment 10

[Rain [:rain1] (inactive)]

Gloda search tab fix pushed to c-c: http://hg.mozilla.org/comm-central/rev/4ad01247f686

Comment 11

[Rain [:rain1] (inactive)]

Attachment: [checked in] patch to fix opening messages from a search window

Hm, I had to rework a lot of the helper code to support selection in the search window. :/

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 386097 [details] [diff] [review]
[checked in] patch to fix opening messages from a search window

You are to be commended for your dedication to and thoroughness in unit
testing.


on file: mail/base/modules/MailUtils.js line 141
>    * @param aViewWrapperToClone [optional] a view wrapper to clone. If null or
>    *                            not given, the message header's folder's
>    *                            default view will be used
>    * @param aTabmail [optional] a tabmail element to use in case we need to

It turns out the syntax for optional things is like so:

@param [aViewWrapperToClone] blah blah blah

See:
http://code.google.com/p/jsdoc-toolkit/wiki/TagParam

Please update all instances of use of [optional] within this patch.

Comment 13

[Rain [:rain1] (inactive)]

Comment on attachment 386097 [details] [diff] [review]
[checked in] patch to fix opening messages from a search window

Pushed to c-c, with [optional] fixed: http://hg.mozilla.org/comm-central/rev/4e87cc8301ee

I think this should be fixed now.

Comment 15

[Wayne Mery (:wsmwk)]

v.fixed
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1pre) Gecko/20090702 Shredder/3.0b3pre