Closed Bug 501235 Opened 15 years ago Closed 15 years ago

add new mochitest sub-harness for docshell testing

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1
Tracking Flags:
Tracking Status
status1.9.1 --- .3-fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2 [Checkin: Comment 4 & 7]
19.70 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
Per discussion with :bz, create a new sub-harness within mochitest chrome for the purpose of making docshell tests easier tow rite.
Attached patch patch v1 (obsolete) — — Splinter Review 
First version of the docshell mochitest sub-harness.  Review comments by :bz incorporated.  As soon as this is reviewed and pushed, I will start submitting test cases on related bug numbers.
Attachment #386145 - Flags: review?(bzbarsky)
You probably want s/bugt/bug/ in the .pl comments.

Why do any of the files other than the docshell_helpers.js need to be installed?

The end of the if/else cascade setting gNavType has weird indentation.

waitForTrue_iterator seems to be unused.

Other than those nits, looks good!
Addressed all of :bz comments. 

Now only installs docshell_helpers.js and generic.html, which is meant to be used by any test.
Attachment #386145 - Attachment is obsolete: true
Attachment #386167 - Flags: review?(bzbarsky)
Attachment #386145 - Flags: review?(bzbarsky)
Attachment #386167 - Flags: review?(bzbarsky) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/f1e7a0072ccf
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
I've verified that this sub-harness works correctly on 1.9.1, along with the test case from bug 303267.
Whiteboard: checkin-needed-1.9.1
(In reply to comment #5)

Thanks.
status1.9.1: ? → ---
Keywords: checkin-needed
Whiteboard: checkin-needed-1.9.1 → [needs 1.9.1.x landing]
Comment on attachment 386167 [details] [diff] [review]
patch v2
[Checkin: Comment 4 & 7]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/261a0fa4249d
Attachment #386167 - Attachment description: patch v2 → patch v2 [Checkin: Comment 7]
status1.9.1: --- → .3-fixed
Keywords: checkin-needed
Whiteboard: [needs 1.9.1.x landing]
Attachment #386167 - Attachment description: patch v2 [Checkin: Comment 7] → patch v2 [Checkin: Comment 4 & 7]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: