50276 - Bookmarks entries in sidebar load into incorrect window

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Scott MacGregor]

I'm sure slamm can point you to the documentation but bookmark links in the
sidebar panel are not written according to the spec for sidebar panels.

In particular, when you click on a link in a sidebar panel, you are supposed to
load a url and target it with a window target of "_content".

Bookmarks instead cheats and just tries to set the location property on the
document. So we don't have the right window target nor the fact that the load is
a result of  alink click.

Why is this a problem?

Because of this, if you click on a bookmark url from your sidebar in mail, we
will always end up trying to load the content in the message pane. This is
because you are just setting the location for the message pane to be the
bookmark url.

If bookmarks instead followed the sidebar panel guidenlines requiring links to
be targeted to _content then the urls would properly end up getting dispatched
to a browser window.

(Because with the window target and the link click information, the uriloader
can properly find the right window for the content). When you just change the
location, the uriloader has know idea it should route the content to a new window.

Comment 1

[Blake Ross]

Reassigning 79 Bookmarks bugs to Ben.  I was told this was going to be done 
shortly about two months ago, but it clearly hasn't been.  I think that's long 
enough for all these bugs to remain assigned to nobody.

Feel free to filter all this spam into the trashcan by looking for this string 
in the message body: ducksgoquack

Comment 2

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is a Netscape beta stopper.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

fix in tree.

Comment 4

[Paul Chen]

Mass moving most of mozilla0.9 bugs to mozilla0.8.1

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Resummarizing so I can look over my buglist easier. 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Fix checked in. 

Comment 7

[Keyser Sose]

*** Bug 69742 has been marked as a duplicate of this bug. ***

Comment 8

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]