50370 - Tab widgets no longer switch tab panels.

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Nikhil Bhatla (gone)]

Build # 2000082508 Windows Commercial
Self-Build this Morning 8/25 on Mac Mozilla

1. Open a new addressbook card by going to FILE > New > New Addressbook Card
2. Click on the "Address" Tab

BUG : Tab panel does not change.

I'm seeing this in modern and classic, on Mac and Windows.  I don't know of any
other places in the app where there are tab widgets (the ones in composer are
implemented differently), so I'm not sure if this is a tab problem or an
addressbook problem.

Comment 1

[Nikhil Bhatla (gone)]

markin nsbeta3

Comment 2

[Peter Trudelle]

->evaughan

Comment 3

[prass]

Aim dogfood bug http://bugscape/show_bug.cgi?id=2120 depends on this. 

Comment 4

[Viswanath Ramachandran]

I'm nominating as a smoketest blocker because the depends AIM bug in bugscape is
a smoketest blocker. This is pretty basic stuff busted near the endgame, we shd
not let it rot too long. thanks, Vishy. 

Comment 5

[Asa Dotzler [:asa]]

this is not a mozilla smoketest blocker.

Comment 6

[leger]

but is is a [dogfood+] since blocking 2120

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

I checked in a new XBL tab control widget on Friday night which replaced the old 
C++ one. I tested the new addressbook card dialog and the editor Advanced Edit 
dialog - both work with the new tab control. I'm grabbing a commercial build now 
to see what's up with AIM. It would be helpful if an AIM person could let me 
know if AIM does anything special with the tab control widget. 

Comment 8

[prass]

The tab widget is switching okay with 08/28 linux build. 
Ccing Andrew since he impletmented the tabs for aim. Andrew do we do anything 
special with the tab widget?

Comment 9

[Robert John Churchill]

I also see this problem with the Bookmark Properties dialog... can't switch to
the "Schedule tab.

Comment 10

[Jon Granrose]

agree w/asa.  not holding the tree for this.  lowering to critical.

Comment 11

[Viswanath Ramachandran]

look at SidebarPanel.xul and SidebarPanel.js in aim for what we do to the tab
there. Ben - this XBLization of C++ tab widget - what bug does that fix?

thanks, Vishy

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in. 

this appears to be a mac classic-only problem. Mac classic tabs and tabboxes 
were not extending the new XBL tab widgets, they were extending xul:box, and 
were thus not getting the appropriate behaviour. 

XBLifying this widget allows for Windows native style tab widgets for 
Classic-Win, and also allows the C++ frames for tabcontrols to be removed from 
the build, which will reduce the size of the layout DLL and help the embedding 
situation. 

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

thanks to andreww for pointing out the problem, also!

Comment 14

[John Morrison]

verified fixed 20000909nn mac/linux/win32 classic/modern