50517 - Inconsistency in migrate profile dialogs

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect, P3)

Description

[Henrik Gemal]

There are 4 ways of encountering a migrate profile. In these 4 ways there should 
be some kind of consistency in the dialogs and text. Currently there isn't.

Problems:
- Sometimes we tell the user that the Netscape 4 profile isn't gonna be altered, 
sometime we dont.
- Sometimes we say press Ok to.. sometimes we dont
- Sometimes we have the "not altered" text on a line of itself, sometimes we 
dont
- Sometimes the dialog is standard windows size sometimes is really wide
- Sometimes the icon is a "i" sometimes it's a "?"
- Sometimes the title is the action (Delete) sometimes is Migrate Profile
- The Confirm Migration Dialog should not have the minimize/maximize buttons

I'll attach a screenshot of the 4 different migrate profiles dialog.

Comment 1

[Henrik Gemal]

Attachment: Screenshot of the different 4 migrate profiles dialogs

Comment 2

[Henrik Gemal]

Attachment: Diff to fix parts of bug

Comment 3

[dbragg]

These are all created and managed by the Profile Manager eventhough they apply 
to migration.  Reassigning to Profile Manager team.

Comment 4

[racham]

Giving this to Ben (ProfileManager frontend).

Comment 5

[Henrik Gemal]

attaching new and updated patch...

Comment 6

[Henrik Gemal]

Attachment: new and better patch

Comment 7

[Blake Ross]

Profile Manager FE bugs --> me

Comment 8

[Blake Ross]

-> Ben

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 10

[Marek Wawoczny]

There is bug in latest patch http://bugzilla.mozilla.org/attachment.cgi?id=23926&action=view
In http://lxr.mozilla.org/mozilla/source/profile/resources/locale/en-US/profileManager.properties#4
You got two properties in one line migratebeforedelete & migratebeforestart. There should be new line before migratebeforestart property.

Comment 11

[Marek Wawoczny]

Reopening due http://bugzilla.mozilla.org/show_bug.cgi?id=50517#c10 and no response ;)

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

oops

fixed

Comment 13

[Grace Bush]

verified on build 2001112603