Closed
Bug 50525
Opened 25 years ago
Closed 22 years ago
Directories should be lowercase
Categories
(SeaMonkey :: Installer, defect, P5)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugzilla, Assigned: ssu0262)
Details
Attachments
(1 file, 2 obsolete files)
|
3.67 KB,
patch
|
ssu0262
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
All other directories created by the installer are lowercase. So should
"Plugins" and "Uninstall".
|
Reporter | |
Comment 1•25 years ago
|
||
|
|
Reporter | |
Comment 2•25 years ago
|
||
Not quite sure where "Plugins" gets created....?
|
|
Reporter | |
Comment 3•25 years ago
|
||
Sean: any chance you get this one in?
It's soo simple...
|
||
Comment 5•25 years ago
|
||
sr=mscott
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 7•24 years ago
|
||
Uninstall folder is now called "uninstall"
Plugins folder is still called "Plugins"
I cant seems to find where the "Plugins" folder is created.
|
|
||
Comment 8•24 years ago
|
||
Marking verified -
If you still want to change the P in Plugins to a lowercase p, it's in the
installation directory.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 9•24 years ago
|
||
ktrina: could you give me a link to where the "Plugins" directory is created?
|
||
Comment 10•24 years ago
|
||
The only uppercase use I could find in
http://lxr.mozilla.org/mozilla/search?string=%22Plugins%22
is in the install script itself, writing to a registry key at
http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/browser.jst#244
That doesn't seem like that would do it, because installing the null plugin from
the browser.jst should have already created that directory with a lower case.
|
|
Reporter | |
Comment 11•24 years ago
|
||
it's kind of weird. The "Plugins" directory gets created right after you press
"Start Install". The only place I can find "Plugins" is:
http://lxr.mozilla.org/mozilla/source/xpinstall/src/nsInstallFolder.cpp#45
Is that use by the installer?
|
|
Reporter | |
Comment 12•24 years ago
|
||
Found it! Will attach a small patch. it's in:
http://lxr.mozilla.org/mozilla/source/xpinstall/packager/windows/config.it#783
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 13•24 years ago
|
||
over to Curt.
Assignee: ssu → curt
Status: REOPENED → NEW
Target Milestone: --- → mozilla0.9.8
|
|
||
Updated•24 years ago
|
Target Milestone: mozilla0.9.8 → ---
|
|
Reporter | |
Comment 14•23 years ago
|
||
Attachment #13611 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 15•23 years ago
|
||
Attachment #72794 -
Attachment is obsolete: true
|
|
||
Comment 16•23 years ago
|
||
Comment on attachment 108200 [details] [diff] [review]
patch to fix remaining issues
Requesting review for this patch
Attachment #108200 -
Flags: review?(dveditz)
|
|
||
Comment 18•23 years ago
|
||
Comment on attachment 108200 [details] [diff] [review]
patch to fix remaining issues
The Force Upgrade items are irrelevant, it's the Destination items that are
creating the paths. But this patch fixes the problem, sr=dveditz
Sean, please check the commercial config.it as well.
Attachment #108200 -
Flags: superreview+
Attachment #108200 -
Flags: review?(ssu)
Attachment #108200 -
Flags: review?(dveditz)
Attachment #108200 -
Flags: review?(ssu) → review+
|
|
||
Comment 19•22 years ago
|
||
This bug has a patch with r/sr, has it been checked in?
|
|
Reporter | |
Comment 20•22 years ago
|
||
Sean: could you check this one in?
|
|
Assignee | |
Comment 21•22 years ago
|
||
patch checked in
Status: NEW → RESOLVED
Closed: 25 years ago → 22 years ago
Resolution: --- → FIXED
|
|
||
Comment 22•22 years ago
|
||
verified 4/21 build
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•