Closed Bug 50612 Opened 24 years ago Closed 24 years ago

remove C++ tab control frames

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: bugs, Assigned: dr)

Details

Tab widgets are now completely implemented in XBL and JS, and any tab control specific frames are no longer needed (the XBL tabcontrol uses a deck internally). evaughan probably knows best what stuff can be removed, but a peek in layout/xul/base/src shows at least two suspiciously named files: nsTabFrame.cpp and nsTabFrame.h.
resummarise to make the intent clearer.
Summary: remove tab control frames → remove C++ tab control frames
word is bond, my brother
Status: NEW → ASSIGNED
oddly, according to LXR, nobody was even referencing these files from c++. fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Shouldn't we also then be able to get rid of the two TCN_SELCHANGE messages that are in /widget/src/windows/nsWindow.cpp (lines 876 and 2708)? There's also one in beos/nsWindow.cpp, but I'd rather leave that for the Be people to mess with.
The BeOS notification message is gone, but there's still two TCN_SELCHANGE messages in /widget/src/windows/nsWindow.cpp, at lines 936 and 2821. Me thinks these should go. Isn't it extraneous code?
You need to log in before you can comment on or make changes to this bug.