51280 - FindNext always receives NULL Search context in webclient test window

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Oleg Khokhlov]

How to reproduce:

1. Run webclient test window and load any URL.
2. Find some string via Search->Find.
3. Close find dialog.
4. Try to find next string via Search->FindNext menu item.

  You will always receive the message: "NULL SearchContext received for 
FindNext".

It is because currentPage.resetFind() is invoked in file EMWindow.java in method 
dialogDismissed(Dialog d).	

May be it's better to make separate menu item for ResetFind?

Mozilla M16 and Webclient source from Sep 04,2000.

P.S. And also currentPage.resetFind() is in method dialogCancelled(Dialog d).

Comment 1

[edburns]

reassign ashu.

Comment 2

[Ashu Kulkarni]

This is part of the Test application code. There is no problem with the
underlying Webclient API code and as the Test code is only a sample for the
Webclient users to build upon, I would not treat this as a Webclient bug.

Nevertheless, I will fix this behavior in the EMWindow code such that it mimics
the actions of the Mozilla browser.

_accept.

_Ashu

Comment 3

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u EMWindow.java

Comment 4

[Ashu Kulkarni]

Attachment: tar.gz of modified patch file

Comment 5

[edburns]

Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14418 :

Ashu, I don't like commented out code.  Please remove the commented out code in 
the fix and re-format the impacted lines.  If you do that, I give r=,a= edburns.

Comment 6

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u EMWindow.java

Comment 7

[Ashu Kulkarni]

Made changes in EMWindow such that resetFind is called only when the "clear"
button is selected. This mimics the behavior of mozilla/Netscape 4.x and IE.
There is no separate ResetFind button.

_Ashu

Comment 8

[Keyser Sose]

Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified