51326 - Method findNextInPage(boolean forward) doesn't use its forward parameter

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Oleg Khokhlov]

Method findNextInPage(boolean forward) doesn't use its forward parameter (see 
CurrentPage.cpp)
This method use forward parameter, which was set in findInPage(java.lang.String 
stringToFind, boolean forward, boolean matchCase) method.

Possible solutions:
1. Remove forward parameter from this method (change findNextInPage(boolean 
forward) to findNextInPage()).
2. Use forward parameter in the body of this method.

Platform: Webclient source from Sep 04,2000.

Comment 1

[edburns]

reassign to ashu

Comment 2

[Ashu Kulkarni]

Thanks for catching this. However, I am not sure, the FindNextInPage functions
should have a "forward" input parameter. This is not in keeping with standard
behavior dislayed by either Netscape 4.x/Mozilla or IE.

_accept.

_Ashu

Comment 3

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u for CurrentPageImpl.cpp

Comment 4

[Ashu Kulkarni]

Attachment: tar.gz of modified files

Comment 5

[edburns]

Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14416 :

You're right it is not consistent to have "forward" param.  This is my fault.  
Nevertheless, let's check this in.  r=a=edburns.  Please file a separate bug 
about the incorrectness of the polarity of the API and assign it to ashu.

Comment 6

[Oleg Khokhlov]

I submitted the separate bug #52239

Comment 7

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u CurrentPageImpl.cpp

Comment 8

[Ashu Kulkarni]

FindNextInPage now uses forward parameter.
See attached patch. Checked into cvs.

_Ashu

Comment 9

[Oleg Khokhlov]

I mark it as verified.