517438 - In FF3.6, Jetpack fails with Error: XULApp is undefined

Status: RESOLVED FIXED

(Mozilla Labs :: Jetpack Prototype, defect, P2)

Description

[Christian Sonne [:cers]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a2pre) Gecko/20090917 Ubuntu/9.04 (jaunty) Namoroka/3.6a2pre
Build Identifier: Firefox: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a2pre) Gecko/20090917 Ubuntu/9.04 (jaunty) Namoroka/3.6a2pre -- jetpack: df8c3190b842+ tip

Line 54 in extension/modules/xulapp.js requires Application.name to be == "Firefox", however at least in my build it's "Firefox-3.6"

Reproducible: Always

Steps to Reproduce:
1. run above-mentioned versions
Actual Results:  
Jetpack fails to start

Comment 1

[Christian Sonne [:cers]]

Attachment: Trivial patch to fix problem

Perhaps something similar can happen in the other products as well? If so,  these should/could be easily fixed in the same manor.

Comment 2

[Clochix]

I have the same problem with Debian's version of Firefox, named 'Iceweasel'. I had to update the test in xulapp.js. I don't know if there's a better way to distinguish between Firefox-like and Thunderbird-like softwares.

Comment 3

[Rex Tsai]

Attachment: fixed the Application.name matching for Ubuntu Firefox and Debian Iceweasel.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 401411 [details] [diff] [review]
Trivial patch to fix problem

>-if (Application.name == "Firefox") {
>+if (Application.name.substring(0,7) == "Firefox") {

This doesn't seem like the ideal way to handle this. Do we have a list of application names that we might have to handle? (e.g. what does iceweasel do?)

Comment 5

[Christian Glahn]

I am not sure if this is related. 

After upgrading to FF 3.6 firefox refuses to run with jetpack from the addon repository as well as with the code from the mercury repository. 

The effect is that firefox seems to bail out while initializing the audio subsystem of jetpack.

As soon jetpack is disabled, firefox 3.6 starts again normally.

The system is Mac OS X 10.6.

Comment 6

[chris hofmann]

looks like bug 543169 might be a dupe of this.

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Explicitly compare against application ids instead of relying on Application.name.

Comment 8

[Atul Varma [:atul]]

Comment on attachment 424672 [details] [diff] [review]
Patch v0.1

Yeah! This rocks.

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/labs/jetpack/rev/cf82b9eb4e68