52157 - Character Encoding: Replace "More >" and "Customize..." with easier to understand names

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P4)

Description

[Katsuhiko Momoi]

** Observed with 9/11/2000 Win32 build **

As dicussed in Bug 47343, the order of Character Coding
menus at the 1st tier is not according to the spec due to
some blocking bugs. 

This forces us to have the following structure on the 1st tier right
now:

 Character Coding --->

                       Auto-Detect 
                       More ...
                       Customize ...
                       ----------------------
                        (Static menu items)
                        (Cached menu items)

================================

This not good UI because the user has no idea as to what "More ..." or 
"Customize ..." mean. We need to come up with better UI.
So until the menus can be ordered according to the spec, we should
come up with alternative UI names. 

Here's one suggestion. (Please suggest others if you can think of
something better.)
==================================
Character Coding --->

                       Auto-Detect 
                       Select other encoding...
                       Customize ...
                       ----------------------
                        (Static menu items)
                        (Cached menu items)

================================

Comment 1

[Frank Tang]

It should never be something "..." since it have sub menu.

Comment 2

[Frank Tang]

Change "More" to "Additional". Mark it as M21

Comment 3

[bobj]

Why is "Additional" any more clear than "More"?

Comment 4

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 5

[Frank Tang]

move all cata's bug to ftang

Comment 6

[Frank Tang]

nhotta- simple change, can you help ?

Comment 7

[nhottanscp]

So "More" to "Select other encoding" and no change for "Customize..."?

Comment 8

[bobj]

"Select other encoding" is too long for a menu item.  We need something
more terse.

Comment 9

[nhottanscp]

So what's wrong with "More"? That's generically used (e.g. more fonts).

Comment 10

[Katsuhiko Momoi]

It's where the menu "More ..." occurs. If it is right after 
encoding items, it make sense, but in this position it does
not.

Comment 11

[Katsuhiko Momoi]

How about "Other encodings"?

Comment 12

[Prognathous]

Please add "Customize..." to the summary-line of this bug. I was just about to
open a new bug.

Ok, here are my suggestions:

I would change "Customize..." to "Customize list...", after all, the list of
encodings is the only thing available for customization. As it is, the word
"Customize" alone, suggests that the user could potentially customize the "User
defined" language using this option (while it's actually done using the Fonts
prefs panel).

As Katsuhiko Momoi suggested, "Other encodings" instead of "More" makes perfect
sense. It is clear and unambiguous.

Prog.

Comment 13

[Prognathous]

Taking bug. It sounds within my very limited coding abilities ;-)

I'm also changing the summary from:
  Character Coding: Need to modify "More.." as something else
to:
  Character Encoding: Replace "More >" and "Customize..." with easier to
understand names

Prog.

Comment 14

[Prognathous]

Attachment: Less ambiguous names for Encoding menu

The patch changes "More" to "More Encodings" and "Customize..." to "Customize
List..."

Prog.

Comment 15

[Simon Montagu :smontagu]

Comment on attachment 153263 [details] [diff] [review]
Less ambiguous names for Encoding menu

I'm not a big fan of compensating for bad UI by modifying menu labels, but I
suppose this doesn't make the UI any worse.

Comment 16

[Prognathous]

Thanks for the reviews. Now, I'd like to get this checked into all three
branches. Is that the way it's done by default when the code is the same?

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd
http://lxr.mozilla.org/mozilla1.7/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd
http://lxr.mozilla.org/aviarybranch/source/xpfe/global/resources/locale/en-US/charsetOverlay.dtd

Prog,

Comment 17

[Asaf Romano (gone)]

Prog, the version of the dtd file for AVIARY is in the new toolkit:
http://lxr.mozilla.org/aviarybranch/source/toolkit/locale/charsetOverlay.dtd

Still, it has the same content.

----
BTW, why whole XPFE is still exists in the AVIARY branch?

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #16)
> Thanks for the reviews. Now, I'd like to get this checked into all three
> branches.

you need to ask for approval for the 1.7 branch (in the edit attachment page,
choose approval1.7.2?). not sure what the policy is for the aviary branch.

Comment 19

[Mike Connor [:mconnor]]

just needs review for aviary, but I'm not sure "Customize List" is really any
better.

Comment 20

[Prognathous]

I've outlined my rational of preferring "Customize List..." in comment 12. Which
part of it do you not agree with, Mike?

Prog.

Comment 21

[Prognathous]

Just to update my previous comment on the subject, "Customize" by itself, hints
that the whole Character Encoding UI+mechanism can be customized (inclue/exclude
sub-menus and options, set default encoding and so on...), while "Customize
List" doesn't suffer from this ambiguity.

Prog.

Comment 22

[Mike Kaply [:mkaply]]

Comment on attachment 153263 [details] [diff] [review]
Less ambiguous names for Encoding menu

We're not taking i18n changes on the 1.7.2 branch, although I admit this one is
probably OK because it doesn't break langpacks. blizzard?

Comment 23

[Asaf Romano (gone)]

CCing blizzard (see last comment).

Comment 24

[Prognathous]

(In reply to comment #19)
> just needs review for aviary, but I'm not sure "Customize List" is really any
> better.

How can I ask for review when the review flag is already set ("smontagu:
review+")? Should I file a new bug for Firefox?

Prog.

Comment 25

[Asaf Romano (gone)]

(In reply to comment #24)
> (In reply to comment #19)
> > just needs review for aviary, but I'm not sure "Customize List" is really any
> > better.
> 
> How can I ask for review when the review flag is already set ("smontagu:
> review+")? Should I file a new bug for Firefox?
> 
> Prog.

Not a new bug, but a version of your patch for the toolkit file (comment 17).

Comment 26

[Mike Connor [:mconnor]]

when you attach the patch, request review at that point.

Comment 27

[Prognathous]

Attachment: Patch for Firefox

Same patch, for Firefox trunk.

Prog.

Comment 28

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on trunk
Checking in charsetOverlay.dtd;
/cvsroot/mozilla/xpfe/global/resources/locale/en-US/charsetOverlay.dtd,v  <-- 
charsetOverlay.dtd
new revision: 1.17; previous revision: 1.16
done

Comment 29

[Prognathous]

Comment on attachment 153458 [details] [diff] [review]
Patch for Firefox

mconnor, can you please review the patch? It would be nice to have the same
Encoding menu in Firefox and Seamonkey. This patch is already checked into
1.8/trunk.

I'm asking for approval-aviary (before I have an r= for the patch), as time is
running out for UI changes.

Thanks,

Prog.

Comment 30

[Mike Kaply [:mkaply]]

Comment on attachment 153458 [details] [diff] [review]
Patch for Firefox

a=mkaply for aviary

Comment 31

[Asaf Romano (gone)]

Simon, can you please check it in?

Comment 32

[Asaf Romano (gone)]

We also need to check it into trunk...

Comment 33

[Simon Montagu :smontagu]

It has been checked into trunk already: see comment 28 and
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/xpfe/global/resources/locale/en-US/charsetOverlay.dtd

Comment 34

[Asaf Romano (gone)]

Firefox/Thunderbird doesn't use xpfe:
toolkit/locale/charsetOverlay.dtd

Comment 35

[Simon Montagu :smontagu]

Oh wait, you meant check in the *firefox* patch into trunk. Sorry, that is now
done too.