52663 - modern2: scrollbar becomes white after pressing escape or stop

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[R.K.Aa.]

saw this yesterday as well a couple of times - now using 2000091408

to repro:
1: load todays bugs in bugzilla
2: scroll down to bottom
3: click "Find" button, and then quickly...
3: go to top of taskbar and click stop-button.

Result: the slidebar button becomes tiny.
If you now click on it, it will vanish.
So will the up/down arrow widgets on scrollbar.

(The scrollbar still works however)


If you have problems reconstructing, try some more times.
(Another error is how scrollbar can becomes completely unresponsive instead.
Reload and try from step 1)

Comment 1

[Peter Trudelle]

->future

Comment 2

[R.K.Aa.]

*** Bug 52731 has been marked as a duplicate of this bug. ***

Comment 3

[R.K.Aa.]

i disagree with futuring this one. It is very common that users click stop
during a page-load, and it will become an extremely visible bug.
It affects the newmod theme. Clicking ESC has same effect, as observed in the
first dup.

Comment 4

[Peter Trudelle]

Feel free to escalate the decision to [e-mail]

Comment 5

[John Morrison]

Two notes: (1) this is only in one skin (newmod). (2) It is the images that 
disappear, not the scrollbar (i.e. scrolling remains fully functional, modulo
the fact that you're not entirely sure where the thumb, etc., is located. 
This is really a layout bug, I think.

Comment 6

[R.K.Aa.]

it may be related to the bug about vanishing buttons (bug 50652) again believed
to be caused by bug 51267 and maybe bug 51249 (just fixed).

Comment 7

[Peter Trudelle]

->evaughan for possible reassignment to layout.

Comment 8

[R.K.Aa.]

additional observation:
What vanishes first is the top and bottom of the scrollbar slider.
The middle of it (with the stripes) remains at this point. (Which is why it
looks so small.)
Clicking it will now make the rest of it disappear too, so will clicking
scrollbar arrows.

Comment 9

[Jesse Ruderman]

I've noticed this on windows too -> all/all.
Could this be related to the esc stopping animations?

Comment 10

[Jesse Ruderman]

Should this be a "themes" bug because it happens only in new modern?

Comment 11

[R.K.Aa.]

probably a "skinability" bug.
As for comment about animation: At the point ESC or stop-button is clicked the
scrollbar isn't animating anything.

I've seen a similar thing when stopping/ESC'ing pages with css;
both colors and images can vanish then. The scrollbar behaviour is likely
described in some .css file? Figuring out why those "faint" when load is stopped
may be the clue to solving this bug as well.

Comment 12

[John Morrison]

Eric, see comments by attinasi at end of bug 49222 (see also dup bug 48411, 
which was for exactly the problem of scrollbar images disappearing when the 
stop/esc is triggered).

Comment 13

[Eric Vaughan]

Well it looks like this happens because hitting the stop button stops all image 
loading even chrome. This wrong it should only apply to html and not the chrome 
in the html. Layout should not be doing this!

nominating for beta3

Comment 14

[Peter Trudelle]

nsbeta3+, P2: Highly visible, loss of basic functionality, workaround not
obvious to end-users.

Comment 15

[Eric Vaughan]

I have a fix for this. I'll post a patch soon. Basically I added an argument 
called aStopChrome to Stop() in nsIPresContext. By default the argument is 
PR_TRUE. If you pass false it stops all images except those that point to chrome 
URLS. Currently all chrome URLs are local to your machine by definition so they 
can't be remote. I think this is a pretty safe solution for 6.0.

Comment 16

[Eric Vaughan]

Attachment: Here is my proposed fixed. Please review

Comment 17

[Marc Attinasi]

Regarding the patch: What is the deal with mImagesStopped on the PresContext?
The new member variable is never initialized and never set, but it is checked in
StartLoadImage? Am I missing something?

Comment 18

[Eric Vaughan]

Attachment: Ok I screwed up and mailed an old patch. Look at this one.

Comment 19

[Eric Vaughan]

Ok all I did is add a variable called mStopChrome which recorded whether or not
chrome had been stopped. If it hasn't it will continue to allow chrome images to
be loaded.

I've tested this on windows and linix and it sees to work pretty well.

Comment 20

[Phil Peterson]

PDT agrees P2

Comment 21

[Eric Vaughan]

fixed

Comment 22

[Eric Vaughan]

fixed

Comment 23

[Jesse Ruderman]

I think that was more of a chrome-specific workaround than a fix.  See bug 
53484 for some similar problems.

Comment 24

[R.K.Aa.]

well a chrome specific workaround was kinda required. Wonder if this will
improve the situation with vanishing buttons too.
When the whole GUI starts to fall apart when clicked on "at the wrong
time"...that's Bad. I hope 53484 is covered by 49222..

Comment 25

[John Morrison]

verified fixed. 20000921nn mac/linux/win32 -- can't get the chrome scrollbars
to white out, etc.