52724 - unused nsAutoString in nsHTMLDocument::CreateElement

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In nsHTMLDocument::CreateElement, I see the lines:

1427   nsAutoString tmp(aTagName);
1428   tmp.ToLowerCase();

The string |tmp| is not used again in the function.  This is either:

 * a waste of two lines, and some string copying and munching
 * obscuring some other bug because you *should* have used tmp later on.

I'm filing this bug to suggest that you either remove the two lines or use tmp
somewhere else in the function, whichever is right. :-)

Comment 1

[Johnny Stenback (:jst)]

Ooohh, good catch David, tmp should be used, but in stead aTagName was used,
this patch fixes the problem:

Index: html/document/src/nsHTMLDocument.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/document/src/nsHTMLDocument.cpp,v
retrieving revision 3.283
diff -u -r3.283 nsHTMLDocument.cpp
--- nsHTMLDocument.cpp  2000/09/19 05:11:59     3.283
+++ nsHTMLDocument.cpp  2000/09/19 07:39:35
@@ -1425,7 +1425,7 @@
   nsAutoString tmp(aTagName);
   tmp.ToLowerCase();

-  mNodeInfoManager->GetNodeInfo(aTagName, nsnull, kNameSpaceID_None,
+  mNodeInfoManager->GetNodeInfo(tmp, nsnull, kNameSpaceID_None,
                                 *getter_AddRefs(nodeInfo));

   nsCOMPtr<nsIHTMLContent> content;

Nominating nsbeta3, this makes document.createElement("a") and
document.createElement("A") create elements that behave differently, and we
don't want that. This is a trivial low risk fix.

Comment 2

[Nisheeth Ranjan]

Yes, this is a trivial, extremely low risk fix.  Marking nsbeta3+

Comment 3

[Johnny Stenback (:jst)]

Fixed

Comment 4

[Jan Carpenter]

dbaron, could you verify please?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified by looking at source