53005 - Unable to build on Win32 due to zip/jar issues

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[rbs]

I have a fresh tree that I pulled today, and my system is hanging when the 
compilation reaches the xpfe directory. Some early symptoms prior to the halt
are enclosed below. Note in particular the "Bad command or file name" due to 
mismatch of "/" and "\". Later on, the system hangs when the following @perl
script is called, with a pop-up error to the effect that the program makes
an attempt to do an invalid write. The only way to exit after that is a clean
reboot. I did a clobber-build and 'rm -r dist', but the problem is still there.

w95make: Entering Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\conten
t\win with target install
Bad command or file name
+++ made chrome C:/Mozilla/src/mozilla/xpfe/browser/resources/content/win => ..\
..\..\..\..\dist\WIN32_D.OBJ\bin\chrome/packages/core.jar
w95make: Leaving Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\content
\win with target install
w95make: Leaving Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\content
 with target install
w95make: Entering Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\locale
 with target install
w95make: Entering Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\locale
\en-US with target install
w95make: Leaving Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\locale\
en-US with target install
w95make: Leaving Directory C:\Mozilla\src\mozilla\xpfe\browser\resources\locale
with target install
w95make: Leaving Directory C:\Mozilla\src\mozilla\xpfe\browser\resources with ta
rget install
Bad command or file name
+++ made chrome C:/Mozilla/src/mozilla/xpfe/browser => ..\..\dist\WIN32_D.OBJ\bi
n\chrome/packages/core.jar

Comment 1

[cls]

warren, clean up your mess, please.

Comment 2

[rbs]

I am finding very strange that the problem is not mentioned by anybody else?

Comment 3

[cls]

Are you using activestate perl or cygwin perl?

Comment 4

[rbs]

activestate

Comment 5

[rbs]

Nominating for nsbeta3. There is no point packaging a m18.tar than cannot be
compiled off the shelves.

Comment 6

[rbs]

Cc:ing additional eyes

Comment 7

[rbs]

Something is definitely wrong/puzzling in my tree since nobody seems to be
having a problem. I am going to do a clean  'rm -r mozilla' to see what
happens...

Comment 8

[Warren Harris]

rbs: do you have zip? What version? 

Try disabling jar packaging and see what happens.

set MOZ_DISABLE_JAR_PACKAGING=1

Comment 9

[rbs]

I think I have WinZip 7. I have already launched the total remove 
(rm -r mozilla) on that system, followed by a pull and clobber build all.
I will be knowing what happened next week when I get back to the system.

Denominating for nsbeta3 since this doesn't appear to be a general problem
affecting other persons. It will be nice though if the mismatch of "/" and "\"
could be avoided to achieve greater portability. 

Comment 10

[cls]

rbs, which version of perl do you have?  I've heard on #mozilla that the 613
build of ActiveState is bad and that users should upgrade to the 616 version. 
I'm using version 522 on win98 w/o a problem.

Also, I'm not sure if winzip has a bin that can be called from the commandline. 
You may want to download zip 2.3.  The link is on the win32 build page,
http://www.mozilla.org/build/win32.html .

Comment 11

[cls]

Attachment: Make MOZ_DISABLE_JAR_PACKAGING actually not make jars

Comment 12

[David Avery]

problem is the ZIP.exe

you need infozip zip.exe V2.3 for windows ( winzip is not good enough)

perl crashes if zip.exe not found

Comment 13

[Pratik Dhupia]

I think I am seeing this error while building on win98. I have zip ver 2.1. zip 
2.3 doesn't work. 

+++ making chrome c:/moz_src/mozilla/xpfe/global  => ..\..\dist\WIN32_D.OBJ\bin\
chrome/en-US.jar
error: file './resources/locale/en-US/globalOverlay.dtd' doesn't exist at ..\..\
config\make-jars.pl line 145, <STDIN> line 49.
NMAKE : fatal error U1077: 'C:\PERL\BIN\perl.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory global with error code 2
NMAKE : fatal error U1077: '..\config\w95make.exe' : return code '0x2'
Stop.

Comment 14

[Pratik Dhupia]

SPAM: adding myself to cc. 

Comment 15

[Warren Harris]

I think this is fixed now. I checked in a patch tonight.

Comment 16

[rbs]

Yes, fixed. Marking VERIFIED. Thanks cls/warren for chasing this one. Along
the way, I got the latest perl 618 and Zip 2.3 out of it...

Comment 17

[rbs]

For the record to others who may experience the problem later: to answer the
"Additional Comments From Pratik  Dhupia 2000-09-24 12:00", this problem arises
when the wrong Zip2.3 is installed. I just got the same problem when
re-installing my build environment after upgrading to W2K. I erronesouly picked
zip23x.zip which is intended for MS-DOS, whereas the correct one to pick is
zip23xN.zip:

C:\Mozilla\src\mozilla>zip -v
Copyright (C) 1990-1999 Info-ZIP
Type 'zip "-L"' for software license.
This is Zip 2.3 (November 29th 1999), by Info-ZIP.
Currently maintained by Onno van der Linden. Please send bug reports to
the authors at [e-mail]; see README for details.

Latest sources and executables are at ftp://ftp.cdrom.com/pub/infozip, as of
above date; see http://www.cdrom.com/pub/infozip/Zip.html for other sites.

Compiled with Microsoft C 12.00 (Visual C++ v6.0) for
Windows 9x / Windows NT (32-bit) on Dec 21 1999.

Zip special compilation options:
        ASM_CRC
        ASMV
        USE_EF_UT_TIME
        NTSD_EAS

Zip environment options:
             ZIP:  [none]
          ZIPOPT:  [none]

Comment 18

[Warren Harris]

Dawn: Is there a list of minimum requirements for building mozilla somewhere? 
Can we add this zip23xN.zip vs zip23x.zip issue to it? Thanks,

Comment 19

[Dawn Endico]

just added a note about this here:

http://mozilla.org/build/win32.html

Comment 20

[amardare]

Hi...
I'm seeing the same behaviour as
Pratik Dhupia reported in "Additional Comments From Pratik Dhupia 2000-09-24 
12:00"

+++ making chrome c:/moz_src/mozilla/xpfe/global  => ..\..\dist\WIN32_D.OBJ\bin\
chrome/en-US.jar
error: file './resources/locale/en-US/globalOverlay.dtd' doesn't exist at ..\..\
config\make-jars.pl line 145, <STDIN> line 49.
NMAKE : fatal error U1077: 'C:\PERL\BIN\perl.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory global with error code 2
NMAKE : fatal error U1077: '..\config\w95make.exe' : return code '0x2'
Stop.

I try to build under win98, I have the zip.exe from zip23xN.zip
and zip -v reports:
>>Copyright (C) 1990-1999 Info-ZIP
>>Type 'zip "-L"' for software license.
>>This is Zip 2.3 (November 29th 1999), by Info-ZIP.
>>Currently maintained by Onno van der Linden. Please send bug reports to
>>the authors at [e-mail]; see README for details.

And still I'm seeing the error. How do I fix this?
Adrian

Comment 21

[rbs]

[...]
Compiled with Microsoft C 12.00 (Visual C++ v6.0) for
Windows 9x / Windows NT (32-bit) on Dec 21 1999.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

is the thing to check.

Comment 22

[amardare]

Here is the output from zip -v

C:\>zip -v
Copyright (C) 1990-1999 Info-ZIP
Type 'zip "-L"' for software license.
This is Zip 2.3 (November 29th 1999), by Info-ZIP.
Currently maintained by Onno van der Linden. Please send bug reports to
the authors at [e-mail]; see README for details.

Latest sources and executables are at ftp://ftp.cdrom.com/pub/infozip, as of
above date; see http://www.cdrom.com/pub/infozip/Zip.html for other sites.

Compiled with Microsoft C 12.00 (Visual C++ v6.0) for
Windows 9x / Windows NT (32-bit) on Dec 21 1999.

Zip special compilation options:
        ASM_CRC
        ASMV
        USE_EF_UT_TIME
        NTSD_EAS

Zip environment options:
             ZIP:  [none]
          ZIPOPT:  [none]

As you can see it's saying:
>Compiled with Microsoft C 12.00 (Visual C++ v6.0) for
>Windows 9x / Windows NT (32-bit) on Dec 21 1999.

And still, I get this:

w95make: Leaving Directory d:\moz\\mozilla\xpfe\global\resources with target 
install
+++ making chrome d:/moz//mozilla/xpfe/global  => ..\..\dist\WIN32_D.OBJ\bin\chr
ome/toolkit.jar
+++ making chrome d:/moz//mozilla/xpfe/global  
=> ..\..\dist\WIN32_D.OBJ\bin\chrome/en-US.jar
error: file './resources/locale/en-US/globalOverlay.dtd' doesn't exist at ..\..\
config\make-jars.pl line 179, <STDIN> line 50.
NMAKE : fatal error U1077: 'D:\PERL\BIN\perl.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory global with error code 2
NMAKE : fatal error U1077: '..\config\w95make.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory xpfe with error code 2
NMAKE : fatal error U1077: '.\config\w95make.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\VC98\BIN\N
MAKE.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\VC98\BIN\N
MAKE.exe"' : return code '0x2'
Stop.

I have the mozilla0.7 source tree and all the utilities installed as it says in
http://www.mozilla.org/build/win32.html.
Any ideas, please.
Adrian

Comment 23

[Daniel (Leaf) Nunes]

are you sure you have the 0.7 sources? there was a problem with the jar 
manifests recently because that file had moved... way after the 0.7 timeframe.

Comment 24

[amardare]

I removed my mozilla0.7 source tree and I downloaded the mozilla 0.8 source 
tree.
I have the same error happening, in the same place.
I searched and I have only one file named zip.exe on my system.

+++ making chrome D:/moz/mozilla/xpfe/global  => ..\..\dist\WIN32_D.OBJ\bin\chro
me/toolkit.jar
+++ making chrome D:/moz/mozilla/xpfe/global  => ..\..\dist\WIN32_D.OBJ\bin\chro
me/en-US.jar
error: file './resources/locale/en-US/globalOverlay.dtd' doesn't exist at ..\..\
config\make-jars.pl line 203, <STDIN> line 53.
NMAKE : fatal error U1077: 'D:\PERL\BIN\perl.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory global with error code 2
NMAKE : fatal error U1077: '..\config\w95make.exe' : return code '0x2'
Stop.
w95make: nmake failed in directory xpfe with error code 2
NMAKE : fatal error U1077: '.\config\w95make.exe' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\VC98\BIN\N
MAKE.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"D:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\VC98\BIN\N
MAKE.exe"' : return code '0x2'
Stop.

This is what perl version:
D:\moz\mozilla>perl -v

This is perl, v5.6.0 built for MSWin32-x86-multi-thread
(with 1 registered patch, see perl -V for more detail)

Copyright 1987-2000, Larry Wall

Binary build 623 provided by ActiveState Tool Corp. http://www.ActiveState.com
Built 16:27:07 Dec 15 2000


Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5.0 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using `man perl' or `perldoc perl'.  If you have access to the
Internet, point your browser at http://www.perl.com/, the Perl Home Page.

This is zip version:
D:\moz\mozilla>zip -v
Copyright (C) 1990-1999 Info-ZIP
Type 'zip "-L"' for software license.
This is Zip 2.3 (November 29th 1999), by Info-ZIP.
Currently maintained by Onno van der Linden. Please send bug reports to
the authors at [e-mail]; see README for details.

Latest sources and executables are at ftp://ftp.cdrom.com/pub/infozip, as of
above date; see http://www.cdrom.com/pub/infozip/Zip.html for other sites.

Compiled with Microsoft C 12.00 (Visual C++ v6.0) for
Windows 9x / Windows NT (32-bit) on Dec 21 1999.

Zip special compilation options:
        ASM_CRC
        ASMV
        USE_EF_UT_TIME
        NTSD_EAS

Zip environment options:
             ZIP:  [none]
          ZIPOPT:  [none]

Does somebody see the same problem I'm seeing?

Adrian

Comment 25

[rbs]

I cvs-updated a fresh tree starting with a nightly snapshot and I *saw* this
problem... Here is what I did to get away from it:

cd xpfe
rm -r resources
cvs -d%CVSROOT% upd -d
nmake makefile.win

Comment 26

[amardare]

It builds OK now.
Thanks,
Adrian

Comment 27

[Daniel Veditz [:dveditz]]

Everyone seems to be happy again...

Comment 28

[Jon Granrose]

verified.