Closed Bug 53116 Opened 24 years ago Closed 24 years ago

crash viewing saved cookies

Categories

(Core :: XBL, defect, P1)

Product:
Core
Component:
XBL
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: danm.moz, Assigned: danm.moz)

References

Details

(Whiteboard: [nsbeta3+])

Tasks -> Privacy & Security -> Cookie Manager -> View Stored Cookies. Mozilla crashes with an infinite stack recursion before the cookie dialog is shown. Note this only happens with the old, superwide, (untabbed), version of the cookie dialog, which seems to happen only when using the Classic skin, and even then, not on the Macintosh. It's a problem on Windows and Linux, though.
Status: NEW → ASSIGNED
Keywords: nsbeta3
Whiteboard: patch in hand
Hmm, I didn't even know about this bug. I've been struggling with bug 52970 which is a dup of this one. See comments in that report. I'll dup that report to this one (rather than vice versa) since dan already has a fix in hand.
*** Bug 52970 has been marked as a duplicate of this bug. ***
Ah. I figured there was already a bug for this, but my search skills apparently suck. This one is a total duplicate of your bug 52970. But oh well. It's an XBL problem anyway, not a cookie thing, and I can fix it as soon as I get bloody permission.
Blocks: 53150
*** Bug 53197 has been marked as a duplicate of this bug. ***
*** Bug 51415 has been marked as a duplicate of this bug. ***
nsbeta3+, p1. This occurrence is somewhat obscure, but it is a general xbl problem that is showing up in other places as well.
Priority: P3 → P1
Whiteboard: patch in hand → patch in hand [nsbeta3+]
Target Milestone: --- → M18
XBL bindings generating anonymous content for elements containing a children element could cause an infinite recursion in nsBoxFrame::GetInsertionPoint. I checked in a specific guard against that case. All better, no crash.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: patch in hand [nsbeta3+] → [nsbeta3+]
*** Bug 51415 has been marked as a duplicate of this bug. ***
verified fixed, particularly for classic skin on win32/linux (Mac Classic is a separate beast by the way). 20000922nn mac/linux/win32 WinClassic/MacClassic/Modern skins.
Status: RESOLVED → VERIFIED
reopening .... seeing this bug again on windows build 2000-09-29-08-M18
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Tracy, did this just start happening? Can you try yesterday's build and see if it crashes or not. If this crash is in the m18 bits, that's very bad.
Tracy, can we get a little more detail here. Crashed doing exactly what (even if you are doing exactly what is stated at the beginning of this bug report, it would good to know that). Note: with the 9-28-MN6 and 9-29-MN6 builds on winNT, I do not crash, in either classic or modern.
Okay, I do get the crash, by simply doing as this bug says "Tasks -> Privacy & Security -> Cookie Manager -> View Stored Cookies" with the trunk windows build 2000-09-29-M18 The crash occurs in nsXBLPrototypeBinding::LocateInstance according to talkback, which is new code that hyatt put on the trunk. This is however code that we very likely want to land on the branch after nsbeta3, as it produces some very big improvements in mailnews performance. Re-resolving this bug as FIXED, since this is an entirely different crash than the original one (despite the similarity of how to reproduce). I will open a new bug for the new crash.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified for the branch bits, and the trunk prior to 09/27.
Status: RESOLVED → VERIFIED
The new bug is bug 54747.
You need to log in before you can comment on or make changes to this bug.