53310 - implement nsMemoryImpl::IsLowMemory() for MacOS

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[Chris Waterson]

Need to implement this routine on MacOS for memory flusher thread to be useful.
Alternatively, add calls to nsIMemory::heapMinimize() in appropriate places.

Comment 1

[anthonyd]

simon, rtm or future? whatever you think is best.

anthonyd

Comment 2

[Simon Fraser [no longer active]]

RTM

Comment 3

[anthonyd]

setting to m19.

anthonyd

Comment 4

[rubydoo123]

Simon, please include the required information per the rtm checkin rules

Comment 5

[Simon Fraser [no longer active]]

Attachment: Diff for nsMemoryImpl.cpp to implement IsLowMemory on Mac

Comment 6

[Simon Fraser [no longer active]]

Looking for an r= (scc?) and sr= (waterson?) on that patch. There is some risk 
here, since we'll be spinning up an extra thread on Mac that we didnt' have 
before. But some debugging shows that the thread runs fine, and doesn't seem to 
cause any problems. If anything, I think it needs to run a little more often.

Comment 7

[rubydoo123]

removing + per pdt sw rules

Comment 8

[Chris Waterson]

Use spaces, not tabs ;-). Fix that, and r=waterson

Comment 9

[Simon Fraser [no longer active]]

Oops, copy-pasted from tabified code (sorry). Will fix the tabs.

Comment 10

[Scott Collins]

...yeah, fix the tabs, and the spelling of |kReserveHeapContigSpace| and all is
well; sr=scc.

Comment 11

[Simon Fraser [no longer active]]

Attachment: Tab-free patch with spelling fix

Comment 12

[Phil Peterson]

rtm++ on the theory that low memory handling will reduce crashers.

Comment 13

[Warren Harris]

Phil: I'm glad you're ++ing this, but I think this one needs some mileage on it 
before landing it on the branch -- just to make sure there isn't some 
side-effect of flushing that we didn't forsee. Mac is the only platform that 
calls flushers when allocation fails (in addition to on the timer like 
on unix/win).

Comment 14

[Simon Fraser [no longer active]]

Fix checked into trunk and branch.

Comment 15

[lchiang]

sfraser: suggestions on how to verify this?

Comment 16

[Simon Fraser [no longer active]]

Source level fix.