53376 - Drag image / link in frames loads image / link

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[Adam]

Mozilla M18 2000091808, Mac OS 9.0.4 -

1) Load http://www.suck.com/ (or any page with frames)
2) Click and hold on one of the images until you are able to drag it
3) Drag it anywhere (as long as you release it somewhere inside the browser window)

The image loads as if you had entered the image URL in the location display
(similar to context menu's "View Image" but it loads in the same browser
window). If the URL to the image is relative, a query is done on the relative
URL (routing you to the Netscape search page, or whatever your default search
plugin is). Basically, the URL of that image is entered into the location field
and loaded.

Comment 1

[Chris Petersen]

Yes, this only happens in frames but is annoying. I have accidentally moved a 
image on a page and it opened in the browser.Happens on Windows 98 as well. 
Tested with the Sept 29 build.

Comment 2

[Kevin McCluskey (gone)]

Marking rtm-. Just not enough time to fix before rtm.

Comment 3

[Eric Pollmann]

Pushing off to Future milestone.  Please let me know if you are blocked by this
bug or would otherwise be harmed by this change, thanks!  :)

Comment 4

[Amarendra Hanumanula]

QA Contact update

Comment 5

[Kevin McCluskey (gone)]

Bulk reassignin HTML FRAME/IFRAME bugs to Eric.

Comment 6

[Kevin McCluskey (gone)]

Bulk re-assigning all of Eric's HTMLFrame bugs to John.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Setting url to useful testcase..

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 146732 [details] [diff] [review]
Patch

jst, would you review?

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 146732 [details] [diff] [review]
Patch

r+sr=jst, even if my eyes hurt when looking at these silly apis of ours.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8a.

Comment 12

[Johnny Stenback (:jst)]

Hmm, I thought this would fix the problem where Mozilla lets you drop a link
into the window where it came from if you drag any link from a window outside
the window and then back. Did I miss something here?

Comment 13

[Boris Zbarsky [:bzbarsky]]

That happened on all pages, not just framed ones... I bet when you cross window
boundaries the "source" document gets clobbered....

Comment 14

[Johnny Stenback (:jst)]

Bz, you know if there's a bug on file on that?

Comment 15

[Boris Zbarsky [:bzbarsky]]

Bug 36867 

Comment 16

[Aaron Kaluszka]

Bz, you said in bug 83963 that this fixed the problem of dragging a link from
one frame to another.  I just checked and if I drag a link (or an image for that
matter) from one frame to another, it still load the link (or image).
seen in both
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8a) Gecko/20040517
and
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8a) Gecko/20040517
Firefox/0.8.0+

Since not even the testcase passes anymore (the dragged image is loaded), I'm
reopening.  Don't know if the check-in got lost somehow...

Comment 17

[Boris Zbarsky [:bzbarsky]]

Aaron, the testcase works fine with a Linux 2004-05-18-07 build -- I can't drag
the image to the lower frame.  This bug (in the core drag/drop code) is in fact
fixed; if there are also OS-specific issues left they should be filed as
separate bugs....

Please make sure you're not using any extensions, etc, by the way.

Comment 18

[Aaron Kaluszka]

Bug 243963 added for Windows case.  No, I don't have any extensions installed.