53478 - Can't hide menus on the Mac.

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[scottputterman]

In mailnews we have code that hides menus based on the context by doing

menuitem.setAttribute("hidden", "true");

this works on Windows and Linux but not the mac.

For example, if you run mail and double click on a message you will get the
standalone message window.  In the View menu the Sort By and Messages menus
shouldn't be there.  Nor should the Message menu item.

Likewise, in the mail 3 pane, in the Messages menu, the Reply to Newsgroup
menuitem should only be there when a news message is selected.  Instead it's
always there.

In Editor, the Check spelling menuitem in the edit menu shouldn't show up unless
the spell checker is installed.  In mozilla builds it's still there.

Comment 1

[scottputterman]

nominating for beta3. reassigning to saari.

Comment 2

[Mike Pinkerton (not reading bugmail)]

taking, i have a fix

Comment 3

[Mike Pinkerton (not reading bugmail)]

fixed.

Comment 4

[Syd Logan]

Shrimp menus are still showing in mac NS 6 on Mac only, regardless of display:
none or visibility: collapse style. Is this the same problem, or a different
one. Reopening, bug if new bug, please file one or let me know and I will do it.
The bug that depends is nsbeta3+ pdt1. This works fine on Windows and Linux,
only a bug on Mac.

buscape bug is http://bugscape/show_bug.cgi?id=2290

Comment 5

[Mike Pinkerton (not reading bugmail)]

of course setting display: none won't do anything, all mac menus are display:none 
all the time, even when visible.

you have to set either the "hidden" or "collapsed" attributes on the menu item.

Comment 6

[Syd Logan]

I tried, those are broken too. Should I open a new bug on that?