53485 - Mozilla too lenient on double-click detection?

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Jesse Ruderman]

From bug 53144:

[Jesse Ruderman, [e-mail]]

Mozilla seems to allow too much space between two clicks to consider the second 
click a double-click.  This might just be my imagination, though.

[Eric Pollmann, [e-mail]]

You're right, there is definitely a difference here.  I may have no rhythm, but
I did this test.  Begin tapping a rhythm out with your non-mousing hand.  Double
click at this pace.  Adjust rhythm until it is *just* slow enough to *not* count
as a double click an Windows native widgets (IE URL bar).  Now double click at
this same pace in Moz's URL bar.  It counts as a double click every time!  (even
slower than this will work, but twice as slow will not)

--------

Windows uses at least two criteria to determine whether something is a double-
click: 
- how far away the clicks are.
- how much time goes by between clicks.

TweakUI lets you change both of these parameters, so Mozilla should read these 
settings on startup.  (I'm assuming that Mozilla is using its own code to 
detect double-clicks rather than relying on the operating system to report 
them.)

Comment 1

[Loco]

Updating QA Contact.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way 
-- please attach your concern to the bug for reconsideration.

Comment 3

[Loco]

Hmm...joki-how hard would it be to fix this issue and have mozilla read info from 
TweakUI?  This seems like an issue that can be terribly annoying (especially in 
conjunction with 53485) in the URL bar [as stated by Jesse Ruderman].  I tend to 
agree here.  On the other hand I don't know if nomination for RTM is warranted if 
we're limited to 100-200 bug fixes (and I'm still bitter about Macs and scrolling 
mouse support).

Any thoughts?

Comment 4

[Jesse Ruderman]

Mozilla also doesn't check if you clicked on the same thing twice.  If you 
click on one thing, move the mouse a pixel, and quickly click on another thing, 
the second thing will get a double-click.  I'm not sure if there is or should 
be a separate bug for this.

Comment 5

[Jesse Ruderman]

See also bug 47966.

Comment 6

[Jesse Ruderman]

comment from [e-mail] in bug 47966:

>The length of time inbetween is determined by a MS-Windows system call. It 
>does seem long, but that is what the system defines.

If we're using the correct length of time, maybe we're measuring from the wrong 
start time.  If I click and hold for a while and then quickly click again in 
IE, the second click is treated as a single click, but if I do the same in 
Mozilla, the second click is treated as a double click.

(cc rods.)

Comment 7

[rods (gone)]

This is not a joki bug, it should be mine.

Jesse is right. I am setting the last clicked time on all mouse events and 
should only be doing it on the MouseDown event.

Comment 8

[rods (gone)]

Attachment: patch to fix

Comment 9

[buster]

seems ok to me.  what's happening on other platforms?  as long as you're in the
code, you should validate that we're doing it right everywhere.  I know lots of
platform zealots who would be happy to test for you!

sr=buster

Comment 10

[Kevin McCluskey (gone)]

patch looks good to me. You might want to consider renaming the global
gLastMsgTime to gLastMouseDownTime.
r=[e-mail]

Comment 11

[rods (gone)]

fixed

Comment 12

[Matthew T (active 1999-2002)]

lordpixel, could you verify this on Mac?

Comment 13

[rods (gone)]

This was Windows only

Comment 14

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 15

[Madhur Bhatia]

QA contact updated

Comment 16

[luis rincon]

verified on build 2001-08-06-trunk