Closed Bug 53697 Opened 25 years ago Closed 25 years ago

xp filepicker not opening because content/global/filepicker.css not in jar.mn

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jag+mozbugs, Assigned: bryner)

Details

(Keywords: regression, Whiteboard: [rtm++] checked in on trunk)

Attachments

(1 file)

[patch] add content/global/filepicker.css to jar.mn
615 bytes, patch
Details | Diff | Splinter Review
This entry seems to be missing from xpfe/components/jar.mn, and prevents the xp filepicker from displaying on jar builds.
Tweaking summary, keyword magic, accepting bug, simple fix, needed for nsbeta3, will block Browser QA test B3, attaching patch.
Severity: normal → blocker
Status: NEW → ASSIGNED
Keywords: nsbeta3, patch, review
Summary: content/global/filepicker.css not in jar.mn → xp filepicker not opening because content/global/filepicker.css not in jar.mn
r=axel@pike.org The ">" icons are really misleading, though the missing css doesn't keep the filepicker from starting. It's just bad UI. Axel
Hmmm, this is nice... When using jar files, missing css files fail silently, the filepicker loads, but with triangles instead of folder icons. When not using jar files, it doesn't load. I'll see if there's a bug on that. Anyway, now I just need a= :-)
Keywords: review → approval
r=/a=ben, and checked in, marking fixed
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Reopening so we can try to land this on the branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: disttsc → bryner
Status: REOPENED → NEW
Keywords: approval → correctness, rtm
Whiteboard: checked in on trunk
Assigning to bryner, who's volunteered lobbying to get this checked in on the branch.
Addding regression kw. This worked up until the landing of JAR files, when someone apparently forgot to add filepicker.css to the jar.mn. Right now, since we fail to load that file, directories get the regular tree twisty icon instead of the folder icon. This would be confusing for the user because these "twisties" CAN NOT be expanded as the icon would suggest. This is an extremely low-risk, trivial fix and I think we should get it in for RTM.
Status: NEW → ASSIGNED
Keywords: regression
rtm+ need info. Ben needs to indicate his a= approval in this bug report before we can change to rtm+
Priority: P3 → P2
Whiteboard: checked in on trunk → [rtm+ need info] checked in on trunk
Target Milestone: --- → M19
r=ben. waterson said he'd provide a= pending this review.
changing to rtm+ per ben's a=.
Whiteboard: [rtm+ need info] checked in on trunk → [rtm+] checked in on trunk
PDT marking [rtm++]
Whiteboard: [rtm+] checked in on trunk → [rtm++] checked in on trunk
checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
verified fixed, trunk and branch.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: