53723 - gray text input boxes are ugly.

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Matthew Miller]

Yuck -- the background for text input boxes is suddenly grey. This looks really
nasty on some otherwise nicely designed pages. I've got my default background
color set to white -- the background for text-entry boxes (at least) should
follow this.

Comment 1

[Dave]

I agree with this. The old style looked much better.

Making text box background the default bg set by the user sounds like it might
be a good idea.

Comment 2

[Decklin Foster]

Ideally i'd like some way to specify this background from within a skin. I'll go
and see if this can be done with the current code.

Does anyone think we can raise severity (to say, Normal) and move this to XP
Toolkit/Widgets? This was caused by Hixie/Pierre's checkin to html.css I believe.

Comment 3

[Brian Ryner (not reading)]

The recent checkin to html.css (rev 3.109) uses 'window' as the
textfield/listbox/combobox background color.  This is a major no-no on Linux
because the window color is a dark gray, whereas the background for these
elements should be white.  These values need to be hardcoded.

For a screenshot, see:  http://www.students.uiuc.edu/~bryner/graybg.jpg

Comment 4

[Decklin Foster]

OK, on GTK we want to pull out the base[NORMAL] state's color for text fields. I
filed bug 52948 to request a CSS color for this. Unfortunately (a) CSS3 is far
from standardization and (b) My code is very incomplete and not tested on
Win/Mac. But, it might get around hardcoding a value.

I'm sure there isn't time to deal with all this before beta3 so hopefully we can
just change it to 'white' until there's a proper CSS color.

Comment 5

[Dave]

cc self

Comment 6

[Hixie (not reading bugmail)]

This requires code level changes or build level changes, neither of which I
can perform. Reassigning to bryner since he seemed to know how to fix this.

Ben: this is the bug we spoke about earlier.

I personally think we should just override GTK on the 'Window' colour and say
that it is white regardless. It would make Yahoo look better, for one. Why does 
GTK think windows should be gray???

Comment 7

[Brian Ryner (not reading)]

This is a regression, too.

Comment 8

[Stuart Parmenter]

window background should be grey (by default (default gtk theme)).  if you want
to specify things like the background of s text field (text field!= window)
using native system colors, i suggest someone add either what the current CSS3
working draft has (field) or make up something moz-field-background.

I think that we should back out the html widgets using native system color
checkin.

reassigning back to hixie

Comment 9

[Decklin Foster]

Pavlov: would the patch I mentioned above work for this?

Comment 10

[Brian Ryner (not reading)]

i've got a patch

Comment 11

[Brian Ryner (not reading)]

Attachment: patch that fixes the problem using -moz-field

Comment 12

[Pierre Saslawsky]

The patch looks fine to me: r=pierre.

Comment 13

[Hixie (not reading bugmail)]

Lorca has more bugs than me, taking QA.

trudelle: Could you give this bug a +? This bug makes Linux builds really ugly 
to the majority of people, and this fix is a simple, good, solution for it.

ben: could you a= this bug please? r=pierre. Also r=ianh given that: BeOS' 
nsLookAndFeel is dead, we don't want xlib to look as good as GTK, and that we
want separate case entries in each switch rather than using fall-through, so
that maintenance is easier later.

Comment 14

[Peter Trudelle]

nsbeta3-, rtm+, extremely visible regression, makes the edit fields appear 
disabled, simple/safe fix.

Comment 15

[Ben Bucksch (:BenB)]

..also makes unchecked checkboxes in classic appear checked, see bug 54457.

Comment 16

[Hixie (not reading bugmail)]

*** Bug 54457 has been marked as a duplicate of this bug. ***

Comment 17

[Phil Peterson]

PDT marking [rtm need info] since super-review is needed on this patch.

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

a=ben

Comment 19

[Peter Trudelle]

rtm+, ready to land

Comment 20

[Phil Peterson]

PDT marking [rtm++]

Comment 21

[Brian Ryner (not reading)]

Fix checked in.

Comment 22

[Decklin Foster]

Verifying fix, thanks.

Comment 23

[djoham]

This is really weird. This bug is fixed on one of my machines (laptop) but not
on my desktop. I've downloaded the same daily build 2000100906. The laptop has
nice white input boxes. The desktop has the ugly gray ones.

It sure looks like the patch to html.css is in on this build.

I've deleted my .mozilla directory.

I've rebooted (hey! I used to use Windows. These things are hard to break)

I've scratched my head.

Does anyone have any idea why on earth these boxes would still be gray? I'll
submit a screenshot to prove I'm not on drugs here.

David

Comment 24

[djoham]

Attachment: screenshot of 2000100906 with gray input boxes

Comment 25

[Brian Ryner (not reading)]

On your desktop machine, are the textbox backgrounds white in other GTK
applications?  We should be following the GTK theme exactly.

Comment 26

[djoham]

...rumages around grumbling trying to find another GTK application....

Yup, that was it. Excellent catch player one! I changed my GTK theme from aqua
to marble3d and things are right with the world once again. I would have never
equated grey text boxes with an Aqua theme...

That's really nifty that it works with GTK themes. 
Here's an RTM--- Any chance of a Window Manager sniff in the future so we can
get KDE2/QT theme support as well? You'll get less bug reports from us KDE users
that way :)

Comment 27

[Benjamin Kahn]

Attachment: Image showing white textboxes in GTK and grey in Mozilla

Comment 28

[Decklin Foster]

The attachment was corrupted, but I could rescue enough of it with the GIMP. it
appears to be a pixmap theme. Are you sure that the theme is not laying a white
pixmap over a gray color? Open the gtkrc and look at base[NORMAL]. Mozilla
should follow that value.