53742 - open web location dialog has no titlebar / can't be moved

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Kathleen :Brade]

This is a mac-specific bug.

When I choose Open Web Location from the File menu, I get the dialog I expect but 
it doesn't have a window title so I can't move the window (perhaps to see the 
urlbar in the window beneath it).

This window has a very non-standard appearance and should be fixed asap.

Comment 1

[Kathleen :Brade]

I'm guessing Simon can fix this bug by changing 2 or fewer lines of code.

add keywords

Comment 2

[Kurt Weinschenker]

Saw this bug on my machine as well, but the window title was there, and I could
move the window anywhere I wanted.

On my machine, the "Open In" pulldown menu was using the *classic* font, even
though I had the "modern" theme engaged.  Curious.

iMac DV, Mac OS 9.0.4, carbon libs 1.0.4, MRJ 2.2.3.

Comment 3

[rubydoo123]

this is a dup of 50388, which PDT downgraded to a p5, if this impedes your work
or impacts you, please resubmit 50388 for consideration. State your issue in
that bug for the PDT to review.


*** This bug has been marked as a duplicate of 50388 ***

Comment 4

[rubydoo123]

sw update

Comment 5

[Simon Fraser [no longer active]]

Not a dup, because it's a different dialog. This is *such* a trivial fix, and has 
quite a big user impact, that I'd like to fix this and 50388 for PR3.

Comment 6

[Kathleen :Brade]

This dialog has a *very* high visibility with our novice and intermediate users.
 This must be fixed for rtm and ideally for nsbeta3.  The fix is very simple and
straightforward.

Comment 7

[rubydoo123]

will consider for rtm+ if the patch is attached, the patch is properly reviewed 
and approved.

Comment 8

[Kurt Weinschenker]

Minor issue:  tested today on PM 9500/Newer G3-250 upgrade, Mac OS 9.04,
2000092804-M18 build.

The grayed-out "Open" window is a pixel high.  When one enters the first
character of a URL or local file, it jumps into the correct position.

Like I said, a minor thing with this build.

Comment 9

[Doron Rosenberg (IBM)]

did this make it into nsbeta3? on windows, still a issue.

Comment 10

[Simon Fraser [no longer active]]

Index: mozilla/editor/ui/composer/content/ComposerCommands.js
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/ComposerCommands.js,v
retrieving revision 1.36
diff -r1.36 ComposerCommands.js
437c437
< 	  window.openDialog( "chrome://navigator/content/openLocation.xul", 
"_blank", "chrome,modal", 0);
---
> 	  window.openDialog( "chrome://navigator/content/openLocation.xul", "_blank", "chrome,modal,titlebar", 0);

brade, please review.
kin, please super-review

Comment 11

[Kathleen :Brade]

r=brade

Comment 12

[kinmoz]

sr=[e-mail]

Comment 13

[Simon Fraser [no longer active]]

All ready to go, removing NEED INFO.

Comment 14

[Phil Peterson]

rtm++

Comment 15

[Simon Fraser [no longer active]]

Fix checked into branch and trunk.

Comment 16

[Doron Rosenberg (IBM)]

I have no mac access, and therefore need someone to verify this. Brade?

Comment 17

[Kathleen :Brade]

Mac is ok; Linux is ok
I'm not booted to Windows right now so someone else will need to verify that.

Comment 18

[timeless]

How did this bug begin w/o an os?

Comment 19

[Doron Rosenberg (IBM)]

win98 2000103004 trunk, worksforme. SO, verifying.