54329 - checkboxes in listboxes can't be checked by [keyboard]navigating up/down and then pressing space.

Status: RESOLVED INVALID

(Core :: XUL, enhancement, P3)

Description

[timeless]

9/26-8
modern2 and clasic
Edit>preferences
Navigator>Toolbars
To save time, click Bookmarks [the text]
press space

results: nothing happens
expect: toggle Bookmarks' checkbox

Comment 1

[Peter Trudelle]

->moz0.9, access issue

Comment 2

[Jesse Ruderman]

Why not just get rid of the checkboxes-in-listbox control and use two columns 
of checkboxes instead?

Comment 3

[Jesse Ruderman]

Btw, tabbing between checkboxes in the listbox doesn't work well either.  In 
Win Classic, tabbing stops when it hits an invisible checkbox.  In Modern, you 
can tab to checkboxes beyond the first four, but the listbox doesn't scroll 
down to make them visible.

Comment 4

[timeless]

you could have 2 columns of 30 checkboxes. you can't reasonably do that w/o 
using some scrolling control, and you should be able to maintain header stuff.  
That leaves degenerative trees and listboxes.

Let's just fix the problem.

Comment 5

[Jesse Ruderman]

Blake made it so the tree control no longer takes focus in bug 66212.  Clicking 
to the right of one of the checkbox items still selects that item in the tree, 
though.  I think clicking there should be the same as clicking on the text of 
the checkbox to the left, but Blake thinks clicking there shouldn't do anything.

Comment 6

[Peter Trudelle]

->ben, per hyatt

Comment 7

[Jesse Ruderman]

se filed bug 68359 for the tabbing problem mentioned earlier on this bug.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

not in .9

Comment 9

[Jesse Ruderman]

Related problems in mail search window: bug 68894, bug 68895.

Comment 10

[Peter Trudelle]

resolving as wfm using today's bits on Win98

Comment 11

[Matthew T (active 1999-2002)]

Reproduced in build 2001052408, Mac OS 9.1. Reopening.

Comment 12

[saari (gone)]

Can someone check if this is still reproduceable on MacOS? (sorry, not running
on Mac today)

Comment 13

[Aaron Leventhal]

It appears that Toolbar prefs don't use a listbox of checkboxes anymore.

I'm not sure there is any current need for this fix.

Should it be marked WONTFIX or Future?

Comment 14

[sairuh (rarely reading bugmail)]

if there are not any other instances of a listbox of checkboxes within the app
[i don't know if there are], then i'd recommend wontfix.

otherwise, if there are places with that widget, then future would be okay for
now...

Comment 15

[John Morrison]

checkbox-in-listbox is used on win32 in the Advanced->System 
(aka pref-winhooks.xul), but not anywhere that I can see on 
Mac and Linux. On win32, this bug does not exist (i.e., space
will toggle state of checkboxes, and tab allows you to navigate,
although not arrow keys). hyatt hints at a revised widget to 
do this in comments at end of bug 68359.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Future. no immediate need

Comment 17

[saari (gone)]

this is now done with listitem type=checkbox, marking invalid